From 24ff7c86756eb0f93b4f65bced58af68c3fed37a Mon Sep 17 00:00:00 2001 From: Ashish Bhasin Date: Sat, 30 Mar 2024 17:12:28 -0300 Subject: [PATCH 1/3] removed 3 design smells --- .../org/imixs/workflow/BPMNRuleEngine.java | 5 ++ .../java/org/imixs/workflow/ModelManager.java | 8 +++ .../workflow/exceptions/PluginException.java | 10 ++++ .../exceptions/WorkflowException.java | 3 ++ .../org/imixs/workflow/MokModelManager.java | 5 ++ .../workflow/TestWorkflowKernelEval.java | 5 ++ .../workflow/engine/AsyncEventScheduler.java | 9 ++-- .../engine/AsyncEventSchedulerConfig.java | 10 ++++ .../workflow/engine/AsyncEventService.java | 9 ++-- .../imixs/workflow/engine/ModelService.java | 52 ++++++++++++++++--- .../workflow/faces/util/ErrorHandler.java | 18 +------ .../faces/util/ValidationException.java | 11 ++++ .../workflow/jaxrs/ModelRestService.java | 45 +--------------- 13 files changed, 115 insertions(+), 75 deletions(-) create mode 100644 imixs-workflow-engine/src/main/java/org/imixs/workflow/engine/AsyncEventSchedulerConfig.java diff --git a/imixs-workflow-core/src/main/java/org/imixs/workflow/BPMNRuleEngine.java b/imixs-workflow-core/src/main/java/org/imixs/workflow/BPMNRuleEngine.java index a6b4a29cc..0066c089b 100644 --- a/imixs-workflow-core/src/main/java/org/imixs/workflow/BPMNRuleEngine.java +++ b/imixs-workflow-core/src/main/java/org/imixs/workflow/BPMNRuleEngine.java @@ -110,6 +110,11 @@ public Model getModelByWorkitem(ItemCollection workitem) throws ModelException { return model; } + @Override + public String modelVersionTableToString(String rootContext) throws ModelException { + return null; + } + } } diff --git a/imixs-workflow-core/src/main/java/org/imixs/workflow/ModelManager.java b/imixs-workflow-core/src/main/java/org/imixs/workflow/ModelManager.java index a6dd99cd8..b82f9ab20 100644 --- a/imixs-workflow-core/src/main/java/org/imixs/workflow/ModelManager.java +++ b/imixs-workflow-core/src/main/java/org/imixs/workflow/ModelManager.java @@ -81,4 +81,12 @@ public interface ModelManager { */ public Model getModelByWorkitem(ItemCollection workitem) throws ModelException; + /** + * Returns the current model information in html format + * @param rootContext + * @return model version table as a html string + * @throws ModelException + */ + String modelVersionTableToString(String rootContext) throws ModelException; + } diff --git a/imixs-workflow-core/src/main/java/org/imixs/workflow/exceptions/PluginException.java b/imixs-workflow-core/src/main/java/org/imixs/workflow/exceptions/PluginException.java index b0787a138..bc7885db3 100644 --- a/imixs-workflow-core/src/main/java/org/imixs/workflow/exceptions/PluginException.java +++ b/imixs-workflow-core/src/main/java/org/imixs/workflow/exceptions/PluginException.java @@ -64,4 +64,14 @@ protected void setErrorParameters(java.lang.Object[] aparams) { this.params = aparams; } + @Override + public String formatErrorMessageWithParameters(String message){ + if (params != null && params.length > 0) { + for (int i = 0; i < params.length; i++) { + message = message.replace("{" + i + "}", params[i].toString()); + } + } + + return message; + } } diff --git a/imixs-workflow-core/src/main/java/org/imixs/workflow/exceptions/WorkflowException.java b/imixs-workflow-core/src/main/java/org/imixs/workflow/exceptions/WorkflowException.java index f0295f2ee..7a5436e36 100644 --- a/imixs-workflow-core/src/main/java/org/imixs/workflow/exceptions/WorkflowException.java +++ b/imixs-workflow-core/src/main/java/org/imixs/workflow/exceptions/WorkflowException.java @@ -85,4 +85,7 @@ public void setErrorCode(String errorCode) { this.errorCode = errorCode; } + public String formatErrorMessageWithParameters(String message){ + return message; + } } diff --git a/imixs-workflow-core/src/test/java/org/imixs/workflow/MokModelManager.java b/imixs-workflow-core/src/test/java/org/imixs/workflow/MokModelManager.java index 4fe666709..22136c7d1 100644 --- a/imixs-workflow-core/src/test/java/org/imixs/workflow/MokModelManager.java +++ b/imixs-workflow-core/src/test/java/org/imixs/workflow/MokModelManager.java @@ -84,4 +84,9 @@ public Model getModelByWorkitem(ItemCollection workitem) throws ModelException { return getModel(workitem.getModelVersion()); } + @Override + public String modelVersionTableToString(String rootContext) throws ModelException { + return null; + } + } diff --git a/imixs-workflow-core/src/test/java/org/imixs/workflow/TestWorkflowKernelEval.java b/imixs-workflow-core/src/test/java/org/imixs/workflow/TestWorkflowKernelEval.java index 7171f46b1..6d77aa212 100644 --- a/imixs-workflow-core/src/test/java/org/imixs/workflow/TestWorkflowKernelEval.java +++ b/imixs-workflow-core/src/test/java/org/imixs/workflow/TestWorkflowKernelEval.java @@ -145,5 +145,10 @@ public Model getModelByWorkitem(ItemCollection workitem) throws ModelException { return model; } + @Override + public String modelVersionTableToString(String rootContext) throws ModelException { + return null; + } + } } diff --git a/imixs-workflow-engine/src/main/java/org/imixs/workflow/engine/AsyncEventScheduler.java b/imixs-workflow-engine/src/main/java/org/imixs/workflow/engine/AsyncEventScheduler.java index 9f931e006..f893f3887 100644 --- a/imixs-workflow-engine/src/main/java/org/imixs/workflow/engine/AsyncEventScheduler.java +++ b/imixs-workflow-engine/src/main/java/org/imixs/workflow/engine/AsyncEventScheduler.java @@ -46,6 +46,8 @@ import jakarta.ejb.TimerService; import java.util.logging.Level; +import static org.imixs.workflow.engine.AsyncEventSchedulerConfig.*; + /** * The AsyncEventScheduler starts a scheduler service to process async events in * an asynchronous way by calling the AsyncEventService. @@ -71,12 +73,7 @@ @Singleton public class AsyncEventScheduler { - public static final String ASYNCEVENT_PROCESSOR_ENABLED = "asyncevent.processor.enabled"; - public static final String ASYNCEVENT_PROCESSOR_INTERVAL = "asyncevent.processor.interval"; - public static final String ASYNCEVENT_PROCESSOR_INITIALDELAY = "asyncevent.processor.initialdelay"; - public static final String ASYNCEVENT_PROCESSOR_DEADLOCK = "asyncevent.processor.deadlock"; - public static final String EVENTLOG_TOPIC_ASYNC_EVENT = "async.event"; // enabled @Inject @@ -95,7 +92,7 @@ public class AsyncEventScheduler { // deadlock timeout interval in ms @Inject - @ConfigProperty(name = AsyncEventScheduler.ASYNCEVENT_PROCESSOR_DEADLOCK, defaultValue = "60000") + @ConfigProperty(name = ASYNCEVENT_PROCESSOR_DEADLOCK, defaultValue = "60000") long deadLockInterval; private static final Logger logger = Logger.getLogger(AsyncEventScheduler.class.getName()); diff --git a/imixs-workflow-engine/src/main/java/org/imixs/workflow/engine/AsyncEventSchedulerConfig.java b/imixs-workflow-engine/src/main/java/org/imixs/workflow/engine/AsyncEventSchedulerConfig.java new file mode 100644 index 000000000..697328dd0 --- /dev/null +++ b/imixs-workflow-engine/src/main/java/org/imixs/workflow/engine/AsyncEventSchedulerConfig.java @@ -0,0 +1,10 @@ +package org.imixs.workflow.engine; + +public class AsyncEventSchedulerConfig { + public static final String ASYNCEVENT_PROCESSOR_ENABLED = "asyncevent.processor.enabled"; + public static final String ASYNCEVENT_PROCESSOR_INTERVAL = "asyncevent.processor.interval"; + public static final String ASYNCEVENT_PROCESSOR_INITIALDELAY = "asyncevent.processor.initialdelay"; + public static final String ASYNCEVENT_PROCESSOR_DEADLOCK = "asyncevent.processor.deadlock"; + + public static final String EVENTLOG_TOPIC_ASYNC_EVENT = "async.event"; +} diff --git a/imixs-workflow-engine/src/main/java/org/imixs/workflow/engine/AsyncEventService.java b/imixs-workflow-engine/src/main/java/org/imixs/workflow/engine/AsyncEventService.java index 728c592c4..db4da35ea 100644 --- a/imixs-workflow-engine/src/main/java/org/imixs/workflow/engine/AsyncEventService.java +++ b/imixs-workflow-engine/src/main/java/org/imixs/workflow/engine/AsyncEventService.java @@ -53,6 +53,9 @@ import jakarta.ejb.TransactionAttributeType; import jakarta.persistence.OptimisticLockException; +import static org.imixs.workflow.engine.AsyncEventSchedulerConfig.ASYNCEVENT_PROCESSOR_ENABLED; +import static org.imixs.workflow.engine.AsyncEventSchedulerConfig.EVENTLOG_TOPIC_ASYNC_EVENT; + /** * The AsyncEventService can be used to process workflow events in an * asynchronous batch process. The AsyncEventService lookup eventLog entries of @@ -89,7 +92,7 @@ public class AsyncEventService { // enabled @Inject - @ConfigProperty(name = AsyncEventScheduler.ASYNCEVENT_PROCESSOR_ENABLED, defaultValue = "false") + @ConfigProperty(name = ASYNCEVENT_PROCESSOR_ENABLED, defaultValue = "false") boolean enabled; private static final Logger logger = Logger.getLogger(AsyncEventService.class.getName()); @@ -140,7 +143,7 @@ public void onProcess(@Observes ProcessingEvent processingEvent) throws ModelExc asyncEventData.setItemValue("timeDuration", boundaryDuration); asyncEventData.setItemValue(WorkflowKernel.TRANSACTIONID, processingEvent.getDocument().getItemValueString(WorkflowKernel.TRANSACTIONID)); - eventLogService.createEvent(AsyncEventScheduler.EVENTLOG_TOPIC_ASYNC_EVENT, + eventLogService.createEvent(EVENTLOG_TOPIC_ASYNC_EVENT, processingEvent.getDocument().getUniqueID(), asyncEventData, cal); } @@ -166,7 +169,7 @@ public void processEventLog() { // test for new event log entries by timeout... List events = eventLogService.findEventsByTimeout(100, - AsyncEventScheduler.EVENTLOG_TOPIC_ASYNC_EVENT); + EVENTLOG_TOPIC_ASYNC_EVENT); if (debug) { logger.log(Level.FINEST, "......found {0} eventLog entries", events.size()); diff --git a/imixs-workflow-engine/src/main/java/org/imixs/workflow/engine/ModelService.java b/imixs-workflow-engine/src/main/java/org/imixs/workflow/engine/ModelService.java index 244693698..9ff9f120d 100644 --- a/imixs-workflow-engine/src/main/java/org/imixs/workflow/engine/ModelService.java +++ b/imixs-workflow-engine/src/main/java/org/imixs/workflow/engine/ModelService.java @@ -30,12 +30,8 @@ import java.io.ByteArrayInputStream; import java.io.InputStream; -import java.util.ArrayList; -import java.util.Collection; -import java.util.Collections; -import java.util.List; -import java.util.Map; -import java.util.Set; +import java.text.SimpleDateFormat; +import java.util.*; import java.util.concurrent.ConcurrentHashMap; import java.util.logging.Level; import java.util.logging.Logger; @@ -524,6 +520,50 @@ public String getDataObject(ItemCollection bpmnElement, String name) { } + public String modelVersionTableToString(String rootContext) throws ModelException{ + List modelVersionList = getVersions(); + StringBuffer buffer = new StringBuffer(); + + for (String modelVersion : modelVersionList) { + + Model model = getModel(modelVersion); + ItemCollection modelEntity = loadModelEntity(modelVersion); + + // now check groups... + List groupList = model.getGroups(); + + buffer.append(""); + + if (modelEntity != null) { + + buffer.append("" + modelVersion + + ""); + + // print upload date... + if (modelEntity != null) { + Date dat = modelEntity.getItemValueDate("$Modified"); + SimpleDateFormat formater = new SimpleDateFormat("yyyy-MM-dd HH:mm:ss"); + buffer.append("" + formater.format(dat) + ""); + } + } else { + buffer.append("" + modelVersion + ""); + buffer.append(" - "); + } + + // Groups + buffer.append(""); + for (String group : groupList) { + // build a link for each group to get the Tasks + + buffer.append("" + + group + "
"); + } + buffer.append(""); + buffer.append(""); + } + return buffer.toString(); + } + /** * This method returns the modelStore or initialize it if not yet created. * diff --git a/imixs-workflow-faces/src/main/java/org/imixs/workflow/faces/util/ErrorHandler.java b/imixs-workflow-faces/src/main/java/org/imixs/workflow/faces/util/ErrorHandler.java index 3b71f1eca..fb3b73bc5 100644 --- a/imixs-workflow-faces/src/main/java/org/imixs/workflow/faces/util/ErrorHandler.java +++ b/imixs-workflow-faces/src/main/java/org/imixs/workflow/faces/util/ErrorHandler.java @@ -155,23 +155,7 @@ public static void addErrorMessage(WorkflowException pe) { } // parse message for params - if (pe instanceof PluginException) { - PluginException p = (PluginException) pe; - if (p.getErrorParameters() != null && p.getErrorParameters().length > 0) { - for (int i = 0; i < p.getErrorParameters().length; i++) { - message = message.replace("{" + i + "}", p.getErrorParameters()[i].toString()); - } - } - } else { - if (pe instanceof ValidationException) { - ValidationException p = (ValidationException) pe; - if (p.getErrorParameters() != null && p.getErrorParameters().length > 0) { - for (int i = 0; i < p.getErrorParameters().length; i++) { - message = message.replace("{" + i + "}", p.getErrorParameters()[i].toString()); - } - } - } - } + pe.formatErrorMessageWithParameters(message); FacesContext.getCurrentInstance().addMessage(null, new FacesMessage(FacesMessage.SEVERITY_INFO, errorCode, message)); diff --git a/imixs-workflow-faces/src/main/java/org/imixs/workflow/faces/util/ValidationException.java b/imixs-workflow-faces/src/main/java/org/imixs/workflow/faces/util/ValidationException.java index 39b8fd0cf..1280e1c72 100644 --- a/imixs-workflow-faces/src/main/java/org/imixs/workflow/faces/util/ValidationException.java +++ b/imixs-workflow-faces/src/main/java/org/imixs/workflow/faces/util/ValidationException.java @@ -63,4 +63,15 @@ protected void setErrorParameters(Object[] aparams) { this.params = aparams; } + @Override + public String formatErrorMessageWithParameters(String message){ + if (params != null && params.length > 0) { + for (int i = 0; i < params.length; i++) { + message = message.replace("{" + i + "}", params[i].toString()); + } + } + + return message; + } + } diff --git a/imixs-workflow-jax-rs/src/main/java/org/imixs/workflow/jaxrs/ModelRestService.java b/imixs-workflow-jax-rs/src/main/java/org/imixs/workflow/jaxrs/ModelRestService.java index ee46802d5..583fe958d 100644 --- a/imixs-workflow-jax-rs/src/main/java/org/imixs/workflow/jaxrs/ModelRestService.java +++ b/imixs-workflow-jax-rs/src/main/java/org/imixs/workflow/jaxrs/ModelRestService.java @@ -30,9 +30,7 @@ import java.io.IOException; import java.io.OutputStream; -import java.text.SimpleDateFormat; import java.util.Arrays; -import java.util.Date; import java.util.List; import java.util.logging.Logger; @@ -54,7 +52,6 @@ import jakarta.ws.rs.core.UriInfo; import org.imixs.workflow.ItemCollection; -import org.imixs.workflow.Model; import org.imixs.workflow.bpmn.BPMNModel; import org.imixs.workflow.engine.DocumentService; import org.imixs.workflow.engine.ModelService; @@ -146,51 +143,13 @@ private void printVersionTable(OutputStream out) { try { StringBuffer buffer = new StringBuffer(); - List modelVersionList = modelService.getVersions(); - // compute rootContext: String rootContext = servletRequest.getContextPath() + servletRequest.getServletPath(); buffer.append(""); buffer.append(""); - for (String modelVersion : modelVersionList) { - - Model model = modelService.getModel(modelVersion); - ItemCollection modelEntity = modelService.loadModelEntity(modelVersion); - - // now check groups... - List groupList = model.getGroups(); - - buffer.append(""); - - if (modelEntity != null) { - - buffer.append(""); - - // print upload date... - if (modelEntity != null) { - Date dat = modelEntity.getItemValueDate("$Modified"); - SimpleDateFormat formater = new SimpleDateFormat("yyyy-MM-dd HH:mm:ss"); - buffer.append(""); - } - } else { - buffer.append(""); - buffer.append(""); - } - - // Groups - buffer.append(""); - buffer.append(""); - - } + // append current model version table as a html string + buffer.append(modelService.modelVersionTableToString(rootContext)); buffer.append("
VersionUploadedWorkflow Groups
" + modelVersion - + "" + formater.format(dat) + "" + modelVersion + " - "); - for (String group : groupList) { - // build a link for each group to get the Tasks - - buffer.append("" - + group + "
"); - } - buffer.append("
"); out.write(buffer.toString().getBytes()); From 65166febd2f9199ebcc6d6b359aafc627e6b6634 Mon Sep 17 00:00:00 2001 From: Ashish Bhasin Date: Sun, 31 Mar 2024 12:18:38 -0300 Subject: [PATCH 2/3] moved modelVersionTableToString to model rest service --- .../org/imixs/workflow/BPMNRuleEngine.java | 6 -- .../java/org/imixs/workflow/ModelManager.java | 8 --- .../imixs/workflow/engine/ModelService.java | 44 -------------- .../workflow/jaxrs/ModelRestService.java | 58 ++++++++++++++++++- 4 files changed, 57 insertions(+), 59 deletions(-) diff --git a/imixs-workflow-core/src/main/java/org/imixs/workflow/BPMNRuleEngine.java b/imixs-workflow-core/src/main/java/org/imixs/workflow/BPMNRuleEngine.java index 0066c089b..d60267c2c 100644 --- a/imixs-workflow-core/src/main/java/org/imixs/workflow/BPMNRuleEngine.java +++ b/imixs-workflow-core/src/main/java/org/imixs/workflow/BPMNRuleEngine.java @@ -109,12 +109,6 @@ public void removeModel(String version) { public Model getModelByWorkitem(ItemCollection workitem) throws ModelException { return model; } - - @Override - public String modelVersionTableToString(String rootContext) throws ModelException { - return null; - } - } } diff --git a/imixs-workflow-core/src/main/java/org/imixs/workflow/ModelManager.java b/imixs-workflow-core/src/main/java/org/imixs/workflow/ModelManager.java index b82f9ab20..a6dd99cd8 100644 --- a/imixs-workflow-core/src/main/java/org/imixs/workflow/ModelManager.java +++ b/imixs-workflow-core/src/main/java/org/imixs/workflow/ModelManager.java @@ -81,12 +81,4 @@ public interface ModelManager { */ public Model getModelByWorkitem(ItemCollection workitem) throws ModelException; - /** - * Returns the current model information in html format - * @param rootContext - * @return model version table as a html string - * @throws ModelException - */ - String modelVersionTableToString(String rootContext) throws ModelException; - } diff --git a/imixs-workflow-engine/src/main/java/org/imixs/workflow/engine/ModelService.java b/imixs-workflow-engine/src/main/java/org/imixs/workflow/engine/ModelService.java index 9ff9f120d..8bb075b4d 100644 --- a/imixs-workflow-engine/src/main/java/org/imixs/workflow/engine/ModelService.java +++ b/imixs-workflow-engine/src/main/java/org/imixs/workflow/engine/ModelService.java @@ -520,50 +520,6 @@ public String getDataObject(ItemCollection bpmnElement, String name) { } - public String modelVersionTableToString(String rootContext) throws ModelException{ - List modelVersionList = getVersions(); - StringBuffer buffer = new StringBuffer(); - - for (String modelVersion : modelVersionList) { - - Model model = getModel(modelVersion); - ItemCollection modelEntity = loadModelEntity(modelVersion); - - // now check groups... - List groupList = model.getGroups(); - - buffer.append(""); - - if (modelEntity != null) { - - buffer.append("" + modelVersion - + ""); - - // print upload date... - if (modelEntity != null) { - Date dat = modelEntity.getItemValueDate("$Modified"); - SimpleDateFormat formater = new SimpleDateFormat("yyyy-MM-dd HH:mm:ss"); - buffer.append("" + formater.format(dat) + ""); - } - } else { - buffer.append("" + modelVersion + ""); - buffer.append(" - "); - } - - // Groups - buffer.append(""); - for (String group : groupList) { - // build a link for each group to get the Tasks - - buffer.append("" - + group + "
"); - } - buffer.append(""); - buffer.append(""); - } - return buffer.toString(); - } - /** * This method returns the modelStore or initialize it if not yet created. * diff --git a/imixs-workflow-jax-rs/src/main/java/org/imixs/workflow/jaxrs/ModelRestService.java b/imixs-workflow-jax-rs/src/main/java/org/imixs/workflow/jaxrs/ModelRestService.java index 583fe958d..d35ffc512 100644 --- a/imixs-workflow-jax-rs/src/main/java/org/imixs/workflow/jaxrs/ModelRestService.java +++ b/imixs-workflow-jax-rs/src/main/java/org/imixs/workflow/jaxrs/ModelRestService.java @@ -30,7 +30,9 @@ import java.io.IOException; import java.io.OutputStream; +import java.text.SimpleDateFormat; import java.util.Arrays; +import java.util.Date; import java.util.List; import java.util.logging.Logger; @@ -52,6 +54,7 @@ import jakarta.ws.rs.core.UriInfo; import org.imixs.workflow.ItemCollection; +import org.imixs.workflow.Model; import org.imixs.workflow.bpmn.BPMNModel; import org.imixs.workflow.engine.DocumentService; import org.imixs.workflow.engine.ModelService; @@ -149,7 +152,7 @@ private void printVersionTable(OutputStream out) { buffer.append(""); buffer.append(""); // append current model version table as a html string - buffer.append(modelService.modelVersionTableToString(rootContext)); + buffer.append(modelVersionTableToString(rootContext)); buffer.append("
VersionUploadedWorkflow Groups
"); out.write(buffer.toString().getBytes()); @@ -454,4 +457,57 @@ public void postModel(XMLDataCollection ecol) { putModel(ecol); } + /** + * Returns the current model information in html format + * @param rootContext + * @return model version table as a html string + * @throws ModelException + */ + private String modelVersionTableToString(String rootContext) throws ModelException{ + List modelVersionList = modelService.getVersions(); + StringBuffer buffer = new StringBuffer(); + + for (String modelVersion : modelVersionList) { + + appendTagsToBuffer(modelVersion, rootContext, buffer); + } + return buffer.toString(); + } + + private void appendTagsToBuffer(String modelVersion, String rootContext, StringBuffer buffer) throws ModelException{ + Model model = modelService.getModel(modelVersion); + ItemCollection modelEntity = modelService.loadModelEntity(modelVersion); + + // now check groups... + List groupList = model.getGroups(); + + buffer.append(""); + + if (modelEntity != null) { + + buffer.append("" + modelVersion + + ""); + + // print upload date... + if (modelEntity != null) { + Date dat = modelEntity.getItemValueDate("$Modified"); + SimpleDateFormat formater = new SimpleDateFormat("yyyy-MM-dd HH:mm:ss"); + buffer.append("" + formater.format(dat) + ""); + } + } else { + buffer.append("" + modelVersion + ""); + buffer.append(" - "); + } + + // Groups + buffer.append(""); + for (String group : groupList) { + // build a link for each group to get the Tasks + + buffer.append("" + + group + "
"); + } + buffer.append(""); + buffer.append(""); + } } From 9667c5d3f192075a44315ddd00acf228c7056e0b Mon Sep 17 00:00:00 2001 From: Ashish Bhasin Date: Sun, 31 Mar 2024 12:25:55 -0300 Subject: [PATCH 3/3] fixed build errors after refactoring --- .../src/test/java/org/imixs/workflow/MokModelManager.java | 5 ----- .../test/java/org/imixs/workflow/TestWorkflowKernelEval.java | 5 ----- 2 files changed, 10 deletions(-) diff --git a/imixs-workflow-core/src/test/java/org/imixs/workflow/MokModelManager.java b/imixs-workflow-core/src/test/java/org/imixs/workflow/MokModelManager.java index 22136c7d1..4fe666709 100644 --- a/imixs-workflow-core/src/test/java/org/imixs/workflow/MokModelManager.java +++ b/imixs-workflow-core/src/test/java/org/imixs/workflow/MokModelManager.java @@ -84,9 +84,4 @@ public Model getModelByWorkitem(ItemCollection workitem) throws ModelException { return getModel(workitem.getModelVersion()); } - @Override - public String modelVersionTableToString(String rootContext) throws ModelException { - return null; - } - } diff --git a/imixs-workflow-core/src/test/java/org/imixs/workflow/TestWorkflowKernelEval.java b/imixs-workflow-core/src/test/java/org/imixs/workflow/TestWorkflowKernelEval.java index 6d77aa212..7171f46b1 100644 --- a/imixs-workflow-core/src/test/java/org/imixs/workflow/TestWorkflowKernelEval.java +++ b/imixs-workflow-core/src/test/java/org/imixs/workflow/TestWorkflowKernelEval.java @@ -145,10 +145,5 @@ public Model getModelByWorkitem(ItemCollection workitem) throws ModelException { return model; } - @Override - public String modelVersionTableToString(String rootContext) throws ModelException { - return null; - } - } }