Add --override-image-id CLI flag for the Modal provider#218
Merged
Conversation
danverbraganza
force-pushed
the
danver/specify-modal-image
branch
from
4a0b7e4 to
9f8de89
Compare
DanverImbue
changed the title
Adds a per-invocation escape hatch: `offload run --override-image-id <ID>`. When passed, Offload runs tests against the given pre-built Modal image as-is and skips its entire image-setup pipeline (Dockerfile build, thin-diff patch, checkpoint cache). This is an invocation-scoped CLI flag only, not a config option. It is threaded to prepare() at runtime via PrepareContext, mirroring how the existing no_cache flag is threaded — nothing is added to the TOML schema. - main.rs: new `override_image_id` arg on `Commands::Run`, threaded through run_tests -> run_remote_provider -> run_prepare. The flag is guarded to the modal provider; using it with any other provider fails early with a clear error. - provider.rs: `override_image_id` field on PrepareContext. - modal.rs: ModalProvider::prepare() short-circuits when the override is set, storing the image ID and emitting one loud warn that the build/patch/cache pipeline is bypassed. Co-authored-by: Sculptor <sculptor@imbue.com>
Add the --override-image-id escape hatch to the `offload run` flag reference, matching the existing table style. Co-authored-by: Sculptor <sculptor@imbue.com>
Co-authored-by: Sculptor <sculptor@imbue.com> Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
danverbraganza
force-pushed
the
danver/specify-modal-image
branch
from
9f8de89 to
aa35f56
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Vet found 1 issue.
[instruction_file_disobeyed] (severity 2/5) (confidence 0.85)
The issue description in .beads/issues.jsonl for code-d9y3 explicitly states 'Do NOT commit .beads/ changes — the Coordinator manages bead state.' Yet the diff includes modifications to .beads/issues.jsonl and .beads/last-touched. These bead state files should not be part of this diff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a per-invocation CLI escape hatch:
offload run --override-image-id <ID>.When passed, Offload runs tests against the given pre-built Modal image exactly
as-is and skips its entire image-setup pipeline — no Dockerfile build, no
thin-diff patch of local changes, no checkpoint cache. For users who have
already built their own Modal image and do not want Offload to build one.
This is an invocation-scoped override. It is a CLI flag only — there are no
changes to the TOML config schema.
Usage
Behavior
--override-image-idis declared on theoffload runsubcommand and threadedto
ModalProvider::prepare()viaPrepareContext, mirroring the existing--no-cacheflag.prepare()short-circuits: it skipsprepare_with_prewarmentirely— the sole entry point to the Dockerfile build, the thin-diff patch, and the
checkpoint cache — and uses the given image ID directly. A loud warning is
logged that image setup is bypassed for this run.
a clear error.
through the normal failure path.
Testing
cargo fmt --check,cargo clippy(no warnings),cargo nextest run(275 passing), and
ratchets checkall pass.prepare()short-circuit, and the non-Modalprovider guard.
🤖 Generated with Claude Code