Merge pull request SummaSolutions#39 from fdinapoli-summasolutions/us_706

Bugfix error message order without a payment

Author: imasson

app/code/MercadoPago/Core/Observer/RefundObserverBeforeSave.php

@@ -74,7 +74,7 @@ protected function creditMemoRefundBeforeSave ($order, $creditMemo)
 
         $isTotalRefund = $payment->getAmountPaid() == $payment->getAmountRefunded();
 
-        $isValidBasicData = $this->checkRefundBasicData ($paymentMethod);
+        $isValidBasicData = $this->checkRefundBasicData ($paymentMethod, $paymentDate);
 
         $isValidaData = $this->checkRefundData ($isCreditCardPayment,
             $orderStatus,
@@ -90,12 +90,18 @@ protected function creditMemoRefundBeforeSave ($order, $creditMemo)
 
     /**
      * @param $paymentMethod
+     * @param $paymentDate
      *
      * @return bool
      */
-    protected function checkRefundBasicData ($paymentMethod) {
+    protected function checkRefundBasicData ($paymentMethod, $paymentDate) {
         $refundAvailable = $this->_dataHelper->isRefundAvailable();
 
+        if ($paymentDate == null) {
+            $this->_messageManager->addErrorMessage(__('No payment is recorded. You can\'t make a refund on a unpaid order'));
+            return false;
+        }
+
         if (!($paymentMethod == 'mercadopago_standard' || $paymentMethod == 'mercadopago_custom')) {
             $this->_messageManager->addErrorMessage(__('Order payment wasn\'t made by Mercado Pago. The refund will be made through Magento'));
             return false;

app/code/MercadoPago/Core/i18n/en_US.csv

@@ -198,4 +198,5 @@
 "Failed to make the refund by Mercado Pago","Failed to make the refund by Mercado Pago"
 "Mercado Pago - Refund not made","Mercado Pago - Refund not made"
 "Order payment wasn't made by Mercado Pago. The refund will be made through Magento", "Order payment wasn't made by Mercado Pago. The refund will be made through Magento"
-"Mercado Pago refunds are disabled. The refund will be made through Magento","Mercado Pago refunds are disabled. The refund will be made through Magento"
+"Mercado Pago refunds are disabled. The refund will be made through Magento","Mercado Pago refunds are disabled. The refund will be made through Magento"
+"No payment is recorded. You can\'t make a refund on a unpaid order","No payment is recorded. You can\'t make a refund on a unpaid order"

app/code/MercadoPago/Core/i18n/es_AR.csv

@@ -202,4 +202,5 @@
 "Failed to make the refund by Mercado Pago","Error al efectuar la devolución mediante Mercado Pago"
 "Mercado Pago - Refund not made","Mercado Pago - Devolución no efectuada"
 "Order payment wasn't made by Mercado Pago. The refund will be made through Magento","El pago de la orden no fue realizado mediante Mercado Pago. La devolución se hará a traves de Magento"
-"Mercado Pago refunds are disabled. The refund will be made through Magento","Las devoluciones de Mercado Pago están deshabilitadas. La devolución se hará a traves de Magento"
+"Mercado Pago refunds are disabled. The refund will be made through Magento","Las devoluciones de Mercado Pago están deshabilitadas. La devolución se hará a traves de Magento"
+"No payment is recorded. You can't make a refund on a unpaid order","No se registra ningún pago. No se pueden hacer devoluciones en ordenes sin pagar"