Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disambiguate more clearly between original ImageJ commands and SciJava modules #285

Closed
ctrueden opened this issue Jul 26, 2023 · 4 comments

Comments

@ctrueden
Copy link
Member

ctrueden commented Jul 26, 2023

One possible solution: the ImageJ command results and SciJava module results could be split to separate tree branches, rather than mixed together under a single "Commands" tree branch. Alternately or in addition, solving #284 would help mitigate the confusion, making this issue less of a concern to me. But I think even with icons it might be nice to separate them out. Or: we could make each branch have an icon, and separate the original ImageJ commands to their own branch, which I think would be clear enough. We can strike a balance between ease of implementation versus reducing ambiguity and user confusion.

@gselzer
Copy link
Collaborator

gselzer commented Jul 26, 2023

@ctrueden I assume this is also a problem in Fiji, yeah? napari-imagej doesn't do anything special with search result categories, there's just a single category for each Searcher implementation. Shouldn't we fix it upstream?

@ctrueden
Copy link
Member Author

In practice, it's not a problem in Fiji because you can differentiate them via the icons—hence my linking to #284 here. But yeah, changes on the Java side might be warranted here: e.g. if we were to finish tackling imagej/imagej-legacy#264, it would change the dynamics of ImageJ vs SciJava commands under the hood, and probably we would want corresponding changes to the searchers to account for that. Are you OK with leaving this issue open on the napari-imagej side until it becomes viable for users to tell the difference between original ImageJ commands and SciJava modules? I'll change the title accordingly.

@ctrueden ctrueden changed the title Consider moving original ImageJ command search results to their own tree branch Disambiguate more clearly between original ImageJ commands and SciJava modules Jul 26, 2023
@gselzer
Copy link
Collaborator

gselzer commented Jul 26, 2023

Are you OK with leaving this issue open on the napari-imagej side until it becomes viable for users to tell the difference between original ImageJ commands and SciJava modules? I'll change the title accordingly.

Yup - I'm 100% on board with filing a PR to add icons to the search results - and if not, we could probably move this issue elsewhere.

@gselzer
Copy link
Collaborator

gselzer commented Nov 11, 2024

As of #290, icons are shown on search results. @ctrueden do you want to file any issues upstream to cover topics we have not yet addressed?

@gselzer gselzer closed this as completed Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants