Skip to content

Commit 037e910

Browse files
sherllyJ. Bruce Fields
authored and
J. Bruce Fields
committed
SUNRPC: Remove unreachable error condition in rpcb_getport_async()
rpcb_getport_async() invokes rpcb_call_async(), which return the value of rpc_run_task() to "child". Since rpc_run_task() is impossible to return an ERR pointer, there is no need to add the IS_ERR() condition on "child" here. So we need to remove it. Signed-off-by: Xiyu Yang <xiyuyang19@fudan.edu.cn> Signed-off-by: Xin Tan <tanxin.ctf@gmail.com> Signed-off-by: J. Bruce Fields <bfields@redhat.com>
1 parent a4abc6b commit 037e910

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

net/sunrpc/rpcb_clnt.c

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -795,12 +795,6 @@ void rpcb_getport_async(struct rpc_task *task)
795795

796796
child = rpcb_call_async(rpcb_clnt, map, proc);
797797
rpc_release_client(rpcb_clnt);
798-
if (IS_ERR(child)) {
799-
/* rpcb_map_release() has freed the arguments */
800-
dprintk("RPC: %5u %s: rpc_run_task failed\n",
801-
task->tk_pid, __func__);
802-
return;
803-
}
804798

805799
xprt->stat.bind_count++;
806800
rpc_put_task(child);

0 commit comments

Comments
 (0)