Skip to content

Update to JUnit5 across all modules #1668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Mar 6, 2021
Merged

Update to JUnit5 across all modules #1668

merged 20 commits into from
Mar 6, 2021

Conversation

charlesfinley
Copy link
Contributor

Update to JUnit5 across all modules

This PR updates the project to JUnit 5 across the board with 1 or 2 exceptions where there are conflicts with some existing tests.

@charlesfinley
Copy link
Contributor Author

I opened Issue #1667 to track the modules that cannot be upgraded at this time.

Copy link
Contributor

@ohbus ohbus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@charlesfinley did you rebase this branch with the master?

@ohbus ohbus self-assigned this Mar 5, 2021
@charlesfinley
Copy link
Contributor Author

@charlesfinley did you rebase this branch with the master?

Yes - this branch is current with master.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 5, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@iluwatar
Copy link
Owner

iluwatar commented Mar 5, 2021

Looks good to me.

This PR updates the project to JUnit 5 across the board with 1 or 2 exceptions where there are conflicts with some existing tests.

@charlesfinley Can you point out these exceptions so we can potentially create a new issue about fixing them?

@charlesfinley
Copy link
Contributor Author

Looks good to me.

This PR updates the project to JUnit 5 across the board with 1 or 2 exceptions where there are conflicts with some existing tests.

@charlesfinley Can you point out these exceptions so we can potentially create a new issue about fixing them?

I've opened Issue #1667 and #1669

@iluwatar
Copy link
Owner

iluwatar commented Mar 5, 2021

Excellent, thank you! 🎉

Copy link
Contributor

@ohbus ohbus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @charlesfinley for upgrading the code and reporting issues with the existing ones.

Your continuous effort helps makes this project an awesome one.

@ohbus ohbus merged commit c150871 into iluwatar:master Mar 6, 2021
@ohbus ohbus added this to the 1.24.0 milestone Mar 6, 2021
@ohbus ohbus linked an issue Mar 7, 2021 that may be closed by this pull request
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use the same JUnit version everywhere
3 participants