-
-
Notifications
You must be signed in to change notification settings - Fork 27.1k
Update to JUnit5 across all modules #1668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to JUnit5 across all modules #1668
Conversation
Bringing my fork current with master
JUnit 4 is not needed when using JUnit-Vintage
Updated update-method module to JUnit 5 (#1542)
I opened Issue #1667 to track the modules that cannot be upgraded at this time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@charlesfinley did you rebase this branch with the master?
Yes - this branch is current with master. |
Kudos, SonarCloud Quality Gate passed! |
Looks good to me.
@charlesfinley Can you point out these exceptions so we can potentially create a new issue about fixing them? |
|
Excellent, thank you! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @charlesfinley for upgrading the code and reporting issues with the existing ones.
Your continuous effort helps makes this project an awesome one.
Update to JUnit5 across all modules
This PR updates the project to JUnit 5 across the board with 1 or 2 exceptions where there are conflicts with some existing tests.