Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 989 batch-2 #1108

Merged
merged 23 commits into from
Dec 18, 2019
Merged

Issue 989 batch-2 #1108

merged 23 commits into from
Dec 18, 2019

Conversation

hbothra15
Copy link
Contributor

In this batch I have update all project having name started with B and C

  • Update all the pom files, need to pay special attention to commander app's pom file which generate multiple jar in single go. This approach was used as this project has multiple main class.
  • It resolves partially #issue-989

hbothra15 and others added 12 commits October 17, 2019 10:48
@hbothra15
Merge pull request #1 from iluwatar/master
b5eb4a4 
Resync
@hbothra15
Merge pull request #2 from iluwatar/master
969a2c7 
Sync from base repo
@hbothra15
Merge pull request #3 from iluwatar/master
2963418 
Sync from master
@hbothra15
Merge pull request #4 from iluwatar/master
4acdfe3 
re-sync from base
Adding support for maven assembly plugin to generate executable jar w…
110f8f2 
…ith all dependencies in built
@hbothra15
Merge pull request #5 from iluwatar/master
1f3c6b1 
Resync to remove conflicts
Merge branch 'master' into issue-989
38199ef
Merge branch 'master' into issue-989
d88a6c5 
# Conflicts:
#	abstract-document/pom.xml
#	pom.xml
Adding maven assemly plugin for projects with name A
eafa3ab
Update in format as per checkstyle, i.e. Spcae in place of tab with s…
5daa724 
…ize of 2
batch set - 2 having all project with B and C
f99b7d7
@hbothra15
Merge branch 'master' into issue-989
7a5a052
@hbothra15
Copy link
Contributor Author

Hi @iluwatar,
Sorry man for the delay, will try to update the batches on weekly basis, as need some office work to deal with.

Regards
@hbothra15

@iluwatar iluwatar self-assigned this Dec 1, 2019
@iluwatar
Copy link
Owner

iluwatar commented Dec 1, 2019

@hbothra15 please resolve the conflicts

iluwatar
iluwatar requested changes Dec 11, 2019
View reviewed changes
@hbothra15 hbothra15 requested a review from iluwatar December 15, 2019 04:46
@iluwatar iluwatar merged commit 7d0a5c0 into iluwatar:master Dec 18, 2019
@iluwatar iluwatar added this to the 1.23.0 milestone Dec 18, 2019
@iluwatar
Copy link
Owner

Thanks @hbothra15 for this batch 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iluwatar iluwatar iluwatar approved these changes

Assignees

@iluwatar iluwatar

Labels
status: under review
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.
3 participants
@hbothra15 @iluwatar @hemant-bothra