-
-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Layered Architecture #2976
Comments
Willing to work on this.
|
Don't know about other IDEs, but in IntelliJ IDEA you can reproduce the warnings by using command 'Analyze - Inspect Code' on the |
Could you assign this issue to me? This is my first time contributing, so I also need some guidance on how to commit and raise a pull request. Thank you! |
Sure @ankurnotwarikoo Here are a couple of good starting points to get started with Github and this project: |
@iluwatar - I am done with the code fixes. However, format the code using checkstlye plugin in Intellij and hence unable to surpass the validation of code. |
Checkstyle is configured here: https://github.com/iluwatar/java-design-patterns/blob/master/pom.xml#L334-L356 It uses built-in Google Checks. We have added some of our own rule suppressions. IDE instructions have some hints on how to work with Checkstyle https://github.com/iluwatar/java-design-patterns/wiki/12.-IDE-instructions |
Noticed that we have a partly duplicate issue #2936 |
This issue has been automatically marked as stale because it has not had recent activity. The issue will be unassigned if no further activity occurs. Thank you for your contributions. |
Description
Layered Architecture example has some code smells.
CakeInfo - 'Optional' used as type for field 'id'
CakeLayerInfo - 'Optional' used as type for field 'id'
CakeToppingInfo - 'Optional' used as type for field 'id'
Acceptance Criteria
The text was updated successfully, but these errors were encountered: