Limit relying on JS execution for checking the element position + increase timeouts for landing page assert that can be too short once in every 20 runs.

Author: ilonatommy

src/Components/test/E2ETest/Infrastructure/WebDriverExtensions/WebDriverExtensions.cs

@@ -3,15 +3,11 @@
 
 using OpenQA.Selenium;
 using OpenQA.Selenium.Support.UI;
-using System;
 
 namespace Microsoft.AspNetCore.Components.E2ETest;
 
 internal static class WebDriverExtensions
 {
-    private static string GetFindPositionScript(string elementId) =>
-        $"return Math.round(document.getElementById('{elementId}').getBoundingClientRect().top + window.scrollY);";
-
     public static void Navigate(this IWebDriver browser, Uri baseUri, string relativeUrl)
     {
         var absoluteUrl = new Uri(baseUri, relativeUrl);
@@ -45,32 +41,33 @@ public static void WaitForElementToBeVisible(this IWebDriver browser, By by, int
 
     public static long GetElementPositionWithRetry(this IWebDriver browser, string elementId, int retryCount = 3, int delayBetweenRetriesMs = 100)
     {
-        var jsExecutor = (IJavaScriptExecutor)browser;
-        string script = GetFindPositionScript(elementId);
-        browser.WaitForElementToBeVisible(By.Id(elementId));
         string log = "";
 
         for (int i = 0; i < retryCount; i++)
         {
             try
             {
-                var result = jsExecutor.ExecuteScript(script);
-                if (result != null)
-                {
-                    return (long)result;
-                }
+                browser.WaitForElementToBeVisible(By.Id(elementId));
+                var element = browser.FindElement(By.Id(elementId));
+                var elementLocation = element.Location.Y;
+
+                // Get scroll position using JavaScript (this is less likely to fail than element positioning)
+                var jsExecutor = (IJavaScriptExecutor)browser;
+                var scrollY = (long)jsExecutor.ExecuteScript("return window.scrollY");
 
-                log += $"Attempt {i + 1}: Script returned null. ";
+                return elementLocation + scrollY;
             }
-            catch (OpenQA.Selenium.JavaScriptException ex)
+            catch (Exception ex)
             {
-                // JavaScript execution failed, retry
-                log += $"Attempt {i + 1}: JavaScriptException - {ex.Message}. ";
+                log += $"Attempt {i + 1}: - {ex.Message}. ";
             }
 
-            Thread.Sleep(delayBetweenRetriesMs);
+            if (i < retryCount - 1)
+            {
+                Thread.Sleep(delayBetweenRetriesMs);
+            }
         }
 
-        throw new Exception($"Failed to execute script to get position for element '{elementId}' after {retryCount} retries. Debug log: {log}");
+        throw new Exception($"Failed to get position for element '{elementId}' after {retryCount} retries. Debug log: {log}");
     }
 }

src/Components/test/E2ETest/ServerRenderingTests/EnhancedNavigationTest.cs

@@ -874,14 +874,14 @@ private void AssertEnhancedNavigation(bool useEnhancedNavigation, IWebElement el
     private void AssertWeAreOnLandingPage()
     {
         string infoName = "test-info-1";
-        Browser.WaitForElementToBeVisible(By.Id(infoName), timeoutInSeconds: 20);
+        Browser.WaitForElementToBeVisible(By.Id(infoName), timeoutInSeconds: 30);
         Browser.Equal("Scroll tests landing page", () => Browser.Exists(By.Id(infoName)).Text);
     }
 
     private void AssertWeAreOnNextPage()
     {
         string infoName = "test-info-2";
-        Browser.WaitForElementToBeVisible(By.Id(infoName), timeoutInSeconds: 20);
+        Browser.WaitForElementToBeVisible(By.Id(infoName), timeoutInSeconds: 30);
         Browser.Equal("Scroll tests next page", () => Browser.Exists(By.Id(infoName)).Text);
     }