Skip to content

Commit 1c4a154

Browse files
strssndktndavem330
authored andcommitted
ipv6: don't accept node local multicast traffic from the wire
Erik Hugne's errata proposal (Errata ID: 3480) to RFC4291 has been verified: http://www.rfc-editor.org/errata_search.php?eid=3480 We have to check for pkt_type and loopback flag because either the packets are allowed to travel over the loopback interface (in which case pkt_type is PACKET_HOST and IFF_LOOPBACK flag is set) or they travel over a non-loopback interface back to us (in which case PACKET_TYPE is PACKET_LOOPBACK and IFF_LOOPBACK flag is not set). Cc: Erik Hugne <erik.hugne@ericsson.com> Cc: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org> Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 74f9f42 commit 1c4a154

File tree

1 file changed

+12
-0
lines changed

1 file changed

+12
-0
lines changed

net/ipv6/ip6_input.c

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,18 @@ int ipv6_rcv(struct sk_buff *skb, struct net_device *dev, struct packet_type *pt
118118
ipv6_addr_loopback(&hdr->daddr))
119119
goto err;
120120

121+
/* RFC4291 Errata ID: 3480
122+
* Interface-Local scope spans only a single interface on a
123+
* node and is useful only for loopback transmission of
124+
* multicast. Packets with interface-local scope received
125+
* from another node must be discarded.
126+
*/
127+
if (!(skb->pkt_type == PACKET_LOOPBACK ||
128+
dev->flags & IFF_LOOPBACK) &&
129+
ipv6_addr_is_multicast(&hdr->daddr) &&
130+
IPV6_ADDR_MC_SCOPE(&hdr->daddr) == 1)
131+
goto err;
132+
121133
/* RFC4291 2.7
122134
* Nodes must not originate a packet to a multicast address whose scope
123135
* field contains the reserved value 0; if such a packet is received, it

0 commit comments

Comments
 (0)