Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No softmax before categorical loss? #282

Open
nirweingarten opened this issue Jul 11, 2021 · 0 comments
Open

No softmax before categorical loss? #282

nirweingarten opened this issue Jul 11, 2021 · 0 comments

Comments

@nirweingarten
Copy link

Hi
Thanks so much for sharing this, what a great repo.
I've noticed that the final actor layer is not really activated, rather a distribution object (say categorical) is used.
Later the log probabilities are taken to compute the actor's loss.
Don't we lose the desired mesh that the softmax function gives us in this case?
IE we encourage good actions and discourage bad actions less then if we'd used softmax, right?
Just wanted to ask is this on propose or did I misunderstand the code?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant