Fix silent fail on player name change #388
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikkentim
reviewed
Nov 25, 2021
| { | ||
| if(PlayerInternal.Instance.SetPlayerName(Id, value) == -1) | ||
| { | ||
| throw new Exception("The name is already in use, too long or has invalid characters."); |
There was a problem hiding this comment.
Could you change it to InvalidOperationException?
There was a problem hiding this comment.
OK. But wait, I'm adding similar return codes handling on the other setters, seems that all lacks these checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #387
Error description taken from here: https://open.mp/docs/scripting/functions/SetPlayerName