Small changes - Accessory #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #117 +/- ##
==========================================
+ Coverage 50.86% 50.94% +0.08%
==========================================
Files 14 14
Lines 1337 1329 -8
Branches 138 138
==========================================
- Hits 680 677 -3
+ Misses 646 641 -5
Partials 11 11
|
ikalchev
reviewed
May 8, 2018
| @@ -487,12 +479,7 @@ def to_HAP(self): | |||
|
|
|||
| .. seealso:: Accessory.to_HAP | |||
| """ | |||
| hap_rep = [super().to_HAP()] | |||
There was a problem hiding this comment.
Not sure if this is more readable or more efficient than the previous version.
There was a problem hiding this comment.
I'm not 100% percent sure either. Just though about that line while I was working on the other PR and it looked pretty cool, especially since we already use list comprehensions in other places (mainly for the to_HAP methods actually).
At least it isn't worse than the before IMO, and it cuts five lines.
There was a problem hiding this comment.
It's not worse, performance-wise I think. Just readability, but it's good enough, Merging
ikalchev
added a commit
that referenced
this pull request
May 18, 2018
* Merge master back into dev (#111) * Fix typo in log message (#112) * Fix typo in SDS011 * Documentation improvements for version 2.0.0 (#114) * Replace event_loop with loop (#107) * Changelog update (#116) * Added entry for event loop change * Additional changes * Small changes - Accessory (#117) * Improved bridge.to_HAP * Updated changelog * Fix another typo in SDS011 which prevented pm10 from getting updates. * Added getter_callback to Characteristic #78 * Fix typo bridge.to_HAP (#119) * Adding Code Style Checker (#118) * Add basis for style checker * Fixed lint errors * Updated changelog * Improvements 7 - Config class (#120) Added a State class which keeps Accessory runtime properties such as port, address, paired clients, etc. This state is stored and managed by the driver. * Remove the pyhap.accessories package. (#115) * Remove the pyhap.accessories package. All accessories are temporarily moved to the root accessories folder. These will be moved into separate repositories as appropriate. pyhap.accessories is now an implicit namespace package. See pyhap/accessories/README.md for how others can share their accessories as HAP-python subpackages. * Release v2.1.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
accessory.create.iid_managerandsetup_idparameter fromaccessoryandbridgeinitcalls.accessory.to_HAP()In theory this is a breaking change. However it's not very likely many people have used those parameters to begin with since the defaults are quite fine. Therefor this shouldn't be an issue.
Some changes are extracted from #104. I didn't wanted to just propose a single new line ;)
In addition this will help keep the other PR clean.