Skip to content

Conversation

@khaeru
Copy link
Member

@khaeru khaeru commented Oct 30, 2025

#430 ← previous PR | following PR → (none)

  • iiasa/message_data#626
  • Implement runs using ExogenousEmissionPrice.
  • Add a SLURM batch script for running mix-models transport on UniCC.
    • Small adjustments and clean-ups to other code to work in this environment.
  • New utility class .sdmx.StructureFactory.

How to review

TBA

PR checklist

  • Continuous integration checks all ✅
  • Add or expand tests; coverage checks both ✅
  • Add, expand, or update documentation.
  • Update doc/whatsnew.

@khaeru khaeru added this to the 2025-12 milestone Oct 30, 2025
@khaeru khaeru self-assigned this Oct 30, 2025
@khaeru khaeru added enh New features or functionality transport MESSAGEix-Transport variant or transport in the base model labels Oct 30, 2025
@khaeru khaeru force-pushed the transport/2025-w44 branch from 3c6c62d to bd49756 Compare October 30, 2025 09:33
@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

❌ Patch coverage is 78.21522% with 83 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.9%. Comparing base (cb47229) to head (eaa3bc2).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
message_ix_models/report/operator.py 44.3% 44 Missing ⚠️
message_ix_models/model/transport/report.py 25.0% 21 Missing ⚠️
message_ix_models/model/transport/plot.py 81.8% 6 Missing ⚠️
message_ix_models/model/transport/build.py 78.5% 3 Missing ⚠️
message_ix_models/cli.py 66.6% 2 Missing ⚠️
message_ix_models/model/transport/operator.py 33.3% 2 Missing ⚠️
message_ix_models/model/workflow.py 60.0% 2 Missing ⚠️
message_ix_models/util/sdmx.py 88.8% 2 Missing ⚠️
message_ix_models/model/buildings/rc_afofi.py 0.0% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main    #447     +/-   ##
=======================================
- Coverage   75.6%   74.9%   -0.8%     
=======================================
  Files        278     279      +1     
  Lines      22740   22892    +152     
=======================================
- Hits       17201   17150     -51     
- Misses      5539    5742    +203     
Files with missing lines Coverage Δ
message_ix_models/__init__.py 100.0% <100.0%> (ø)
message_ix_models/model/emissions.py 98.7% <100.0%> (ø)
message_ix_models/model/transport/__init__.py 100.0% <100.0%> (ø)
message_ix_models/model/transport/config.py 99.4% <100.0%> (+0.5%) ⬆️
message_ix_models/model/transport/data.py 98.9% <ø> (ø)
message_ix_models/model/transport/demand.py 100.0% <ø> (ø)
message_ix_models/model/transport/key.py 100.0% <100.0%> (ø)
message_ix_models/model/transport/passenger.py 96.6% <100.0%> (ø)
message_ix_models/model/transport/policy.py 100.0% <100.0%> (ø)
message_ix_models/model/transport/slurm.py 100.0% <100.0%> (ø)
... and 29 more

... and 10 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@khaeru khaeru force-pushed the transport/2025-w44 branch from bd49756 to 1be671a Compare October 31, 2025 10:29
@khaeru khaeru mentioned this pull request Nov 6, 2025
7 tasks
@khaeru khaeru force-pushed the transport/2025-w44 branch 3 times, most recently from 7a6303d to bc4ca5e Compare November 12, 2025 14:21
khaeru added a commit that referenced this pull request Nov 18, 2025
@khaeru khaeru force-pushed the transport/2025-w44 branch 2 times, most recently from b4bd5ae to 2e4fe45 Compare November 19, 2025 15:52
khaeru added a commit that referenced this pull request Nov 21, 2025
@khaeru khaeru force-pushed the transport/2025-w44 branch 7 times, most recently from b133d02 to ecde703 Compare November 25, 2025 14:29
- Add --remote option for using SSH via fabric.
- New Template class for templating Slurm `sbatch` scripts.
- Add --module/-m option for locating templates in submodules of
  message-ix-models.
- Add fabric to packages without type hints.
- Update tests.
- Use a better name for 'needs_log_file' local in .cli.main().
- add_tasks() methods to set up the build Computer to prepare data to
  represent these policies.
- prepare_computer() to invoke these methods according to the Policy
  instances present in .transport.Config.policy.
- Add .transport.policy to default .transport.Config.modules.
- Expand CHECKS for data created by .transport.policy.
- Rely instead on .transport.policy.prepare_computer() to chain to
  distinct Policy subclasses.
- Call .model.workflow.step_0() directly; don't remove data for
  tax_emission added in the transport build step.
- Move from .transport.report and generalize.
- Rely on .report.operator.latest_reporting().
- Use .iamc.to_quantity().
- Structure operations internally using genno.Computer.
- Add .plot.prepare_computer(…, kind=…, target=…) keyword arguments.
- Filter plots to add using `kind`.
@khaeru khaeru force-pushed the transport/2025-w44 branch from ecde703 to eaa3bc2 Compare November 25, 2025 16:03
@khaeru khaeru force-pushed the transport/2025-w44 branch 2 times, most recently from 10f2fc3 to dcab36b Compare November 26, 2025 16:34
- Incorporate features from .transport.plot.Plot.
  - New attributes strage, single.
  - Remove url attribute.
- Add PlotFromIAMC, PlotTimeSeries subclasses; adjust existing plots.
- New COMMON global collection of plotnine elements.
- Move items from .transport.plot: LabelFirst, change level of
  matplotlib logger.
- New functions collect() and prepare_computer().
- Use prepare_computer() in callback(); remove PLOTS global.
- Use in .transport.build instead of hard-coded string.
@khaeru khaeru force-pushed the transport/2025-w44 branch from dcab36b to 81fee17 Compare November 26, 2025 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enh New features or functionality transport MESSAGEix-Transport variant or transport in the base model

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant