Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test and improve .model.material #194

Open
macflo8 opened this issue May 24, 2024 · 1 comment
Open

Test and improve .model.material #194

macflo8 opened this issue May 24, 2024 · 1 comment
Labels
enh New features or functionality material MESSAGEix-Materials variant

Comments

@macflo8
Copy link
Contributor

macflo8 commented May 24, 2024

This is a tracking issue for follow-up items from #188 and #189 . Create 1 or more PRs and (if necessary to keep discussion organized) issues to address:

@macflo8 macflo8 changed the title Test .model.material Test and improve .model.material May 24, 2024
@macflo8 macflo8 changed the title Test and improve .model.material Test and improve .model.material May 24, 2024
@glatterf42 glatterf42 added enh New features or functionality material MESSAGEix-Materials variant labels May 24, 2024
@khaeru
Copy link
Member

khaeru commented May 24, 2024

Another item to add: packaging

  • Looking at this workflow run, we see a number of .xlsx files in /data/material/ are included in the build .whl and .tar.gz distributions.
  • For the .water module and others, we have taken the approach of excluding these files from the distribution, and providing a function/CLI command to fetch these files from GitHub. See Miscellaneous enhancements for 2023-W44 #137 (mixed with many other changes, sorry). See also Data, metadata, and configuration in the docs.
  • With that approach, the installation of message-ix-models remains small, and then users can fetch the data that they want to use. We don't force e.g. .water-focused users to download .material data, or vice versa.
  • I would like to do this before we make a new release of message-ix-models that includes these materials .xlsx files.
  • This is more or less orthogonal to Develop better input data system for MESSAGEix-Materials #193, i.e. it applies whether the data files are CSV or Excel or any other format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enh New features or functionality material MESSAGEix-Materials variant
Projects
None yet
Development

No branches or pull requests

3 participants