Change memory address data type from short to ushort

Author: KanaHayama

Components/ParallelPorts.Windows.WPF/HexShortConverter.cs renamed to Components/ParallelPorts.Windows.WPF/HexUShortConverter.cs

@@ -5,20 +5,20 @@
 using System.Windows.Data;
 
 namespace OpenSense.WPF.Components.ParallelPorts {
-    internal sealed class HexShortConverter : IValueConverter {
+    internal sealed class HexUShortConverter : IValueConverter {
         public object Convert(object value, Type targetType, object parameter, CultureInfo culture) {
-            return value is short s ? s.ToString("X4") : string.Empty;
+            return value is ushort s ? s.ToString("X4") : string.Empty;
         }
 
         public object ConvertBack(object value, Type targetType, object parameter, CultureInfo culture) {
             var text = value?.ToString();
             return string.IsNullOrWhiteSpace(text) ? 
-                (short)0
+                (ushort)0
                 :
-                short.TryParse(text.Trim(), NumberStyles.HexNumber, null, out var result) ?
+                ushort.TryParse(text.Trim(), NumberStyles.HexNumber, null, out var result) ?
                     result 
                     : 
-                    (short)0;
+                    (ushort)0;
         }
     }
 }

Components/ParallelPorts.Windows.WPF/ParallelPortPinPullerConfigurationControl.xaml

@@ -16,8 +16,8 @@
     <UserControl.Resources>
         <local:HexByteConverter
             x:Key="HexByteConverter" />
-        <local:HexShortConverter
-            x:Key="HexShortConverter" />
+        <local:HexUShortConverter
+            x:Key="HexUShortConverter" />
     </UserControl.Resources>
     <Grid>
         <Grid.ColumnDefinitions>
@@ -48,7 +48,7 @@
         <TextBox
             Grid.Row="0"
             Grid.Column="1"
-            Text="{Binding MemoryAddress, Converter={StaticResource HexShortConverter}, Mode=TwoWay, UpdateSourceTrigger=PropertyChanged}" />
+            Text="{Binding MemoryAddress, Converter={StaticResource HexUShortConverter}, Mode=TwoWay, UpdateSourceTrigger=PropertyChanged}" />
 
         <TextBlock
             Grid.Row="1"

Components/ParallelPorts.Windows/ParallelPortPinPuller.cs

@@ -15,12 +15,12 @@ public sealed class ParallelPortPinPuller : IConsumer<byte>, IProducer<byte>, IN
         #endregion
 
         #region Options
-        private short memoryAddress = 0x378;
+        private ushort memoryAddress = 0x0378;
 
         /// <remarks>
-        /// Inpoutx64 uses signed short for memory address. Here we follow its convention.
+        /// Inpoutx64 uses signed short for memory address. Here we use common convention of unsigned short.
         /// </remarks>
-        public short MemoryAddress {
+        public ushort MemoryAddress {
             get => memoryAddress;
             set => SetProperty(ref memoryAddress, value);
         }
@@ -88,7 +88,7 @@ private void OnPipelineRun(object? sender, PipelineRunEventArgs e) {
             if (!SetOnStart) {
                 return;
             }
-            Inpoutx64PInvoke.Out32(MemoryAddress, SetOnStartValue);
+            Inpoutx64PInvoke.Out32((short)MemoryAddress, SetOnStartValue);
             var timestamp = UseSourceOriginatingTime ? e.StartOriginatingTime : Out.Pipeline.GetCurrentTime();
             Out.Post(SetOnStartValue, timestamp);
         }
@@ -97,12 +97,12 @@ private void OnPipelineCompleted(object? sender, PipelineCompletedEventArgs e) {
             if (!SetAfterStop) {
                 return;
             }
-            Inpoutx64PInvoke.Out32(MemoryAddress, SetAfterStopValue);
+            Inpoutx64PInvoke.Out32((short)MemoryAddress, SetAfterStopValue);
         }
         #endregion
 
         private void Process(byte value, Envelope envelope) {
-            Inpoutx64PInvoke.Out32(MemoryAddress, value);
+            Inpoutx64PInvoke.Out32((short)MemoryAddress, value);
             var timestamp = UseSourceOriginatingTime ? envelope.OriginatingTime : Out.Pipeline.GetCurrentTime();
             Out.Post(value, timestamp);
         }

Components/ParallelPorts.Windows/ParallelPortPinPullerConfiguration.cs

@@ -9,12 +9,12 @@ public class ParallelPortPinPullerConfiguration : ConventionalComponentConfigura
         private static readonly ParallelPortPinPullerMetadata Metadata = new();
 
         #region Settings
-        private short memoryAddress = 0x378;
+        private ushort memoryAddress = 0x0378;
 
         /// <remarks>
-        /// Inpoutx64 uses signed short for memory address. Here we follow its convention.
+        /// Inpoutx64 uses signed short for memory address. Here we use common convention of unsigned short.
         /// </remarks>
-        public short MemoryAddress {
+        public ushort MemoryAddress {
             get => memoryAddress;
             set => SetProperty(ref memoryAddress, value);
         }