Feature/alex behaviors #1123
Merged
Feature/alex behaviors #1123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuigiPenco93
commented
Nov 25, 2025
| FrameBox3DBasics footShape = newBoxWithSTP(ankleRollFrame, new Vector3D(0.26, 0.14, 0.055)); | ||
| footShape.getPosition().set(0.045, 0.0, -0.05); | ||
| collidables.add(new Collidable(foot, collisionMask, collisionGroup, footShape)); | ||
| if (ankleRoll != null) |
Contributor
Author
There was a problem hiding this comment.
these collisions are used by the desired robot of the behavior actions, for whatever reason the ankle roll is null there. I don't think it's needed anywhere
ds58
approved these changes
Dec 1, 2025
calvertdw
reviewed
Dec 1, 2025
| if (objectType.equals(IsaacROSFoundationPoseObject.MUSTARD)) | ||
| modelName = "environmentObjects/mustard/mustard.glb"; | ||
|
|
||
| String modelName = "environmentObjects/" + objectType.meshName + "/" + objectType.meshName + ".glb"; |
Member
There was a problem hiding this comment.
These meshes don't exist, you'll crash the app I think. I only made it for the mustard so far.
calvertdw
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.