Performance Improvements #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igrigorik
reviewed
Apr 11, 2017
lib/core_extensions/array.rb
Outdated
| result[i] += 1 | ||
| end.values.inject(0) do |sum, count| | ||
| percentage = count.to_f / length | ||
| sum + -percentage * Math.log2(percentage) |
There was a problem hiding this comment.
I guess we can simplify to sum - ...? :)
There was a problem hiding this comment.
Good point! Fixed here and in another place in id3_tree.rb
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was using the Bagging with a large amount of data and it was really slow. I've made some improvements (though it's still pretty slow ;).
The biggest improvement was pulling out the
index = attributes.index(attribute)so that it didn't happen over and over again in each loop.It also seemed like the
fitnessvariable was being used, but I was only using thediscrete. I'm happy to put that back if that's not true forcontinuous