Simplify with #sum

igrigorik · Apr 11, 2017 · 13aed0b · 13aed0b
1 parent 868ed91
commit 13aed0b
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/lib/.DS_Store b/lib/.DS_Store
diff --git a/lib/core_extensions/array.rb b/lib/core_extensions/array.rb
@@ -2,9 +2,10 @@ class Array
   def entropy
     each_with_object(Hash.new(0)) do |i, result|
       result[i] += 1
-    end.values.inject(0) do |sum, count|
+    end.values.sum do |count|
       percentage = count.to_f / length
-      sum + -percentage * Math.log2(percentage)
+
+      -percentage * Math.log2(percentage)
     end
   end
 end

diff --git a/lib/decisiontree/id3_tree.rb b/lib/decisiontree/id3_tree.rb
@@ -120,12 +120,12 @@ def id3_discrete(data, attributes, attribute)
       index = attributes.index(attribute)
 
       values = data.map { |row| row[index] }.uniq
-      remainder = values.sort.inject(0) do |sum, val|
+      remainder = values.sort.sum do |val|
         classification = data.each_with_object([]) do |row, result|
           result << row.last if row[index] == val
         end
 
-        sum + ((classification.size.to_f / data.size) * classification.entropy)
+        ((classification.size.to_f / data.size) * classification.entropy)
       end
 
       [data.classification.entropy - remainder, index]