chore: update arpack to arpack-ng 3.9.1 #1559
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current Aviator status
This pull request is currently open (not queued). How to mergeTo merge this PR, comment
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@krlmlr You asked to update ARPACK to the latest ARPACK-NG. This PR attempts to do that. It was quite painful: first we need to rename functions to have an igraph prefix, and avoid conflicts. This can be done automatically. But then the line lengths exceed 72 characters, which is the maximum for fixed-form Fortran, and we need to manually reformat them, with the appropriate continuation character. I hope I didn't mess this up.
The changes to snapshots are fine. But there's a failure with spectral clustering, and it's unclear to me whether that's a real failure or not. I'll have another look at this when teaching is over (mid-November).