-
-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Stop accepting setting layout
as a graph attribute if it is a matrix
#1303
base: main
Are you sure you want to change the base?
Conversation
Current Aviator status
This pull request is currently open (not queued). How to mergeTo merge this PR, comment
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
98c16fd
to
f335f4e
Compare
This pull request failed to merge: this PR is in draft state. Remove the Additional debug info: PR was marked as draft after queueing |
This pull request can't be queued because it's currently a draft. |
Then there will need to be a convenient way to enter the layout information as vertex attributes ( I'm not exactly sure what features exist for this. There's e.g. |
Accept a vertex attribute |
Something of that sort, yes. The problem is that the function that compute layouts return matrices. But in order to store layouts in graphs properly, we need to split these matrices into x, y and maybe z components. For convenience, there should be some easy way to convert between the two representations. In particular, there should be a very easy way to compute a layout (produced as a matrix) and store it in the graph as x, y vertex attributes. Perhaps the (If you ask me, the best solution would be if coordinate tuples could be stored in a single "position" vertex attribute, but unfortunately the C core inly supports scalars at the moment, not vectors/tuples, as attribute values associated with individual vertices. I hope we get the new grant from the CZI and can work on improving this.) |
layout
as a graph attribute if it is a matrixlayout
as a graph attribute if it is a matrix
Closes #775.
@maelle: Can you please pick up from here?