Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warnings in iterators.R #1555

Open
maelle opened this issue Oct 15, 2024 · 3 comments
Open

warnings in iterators.R #1555

maelle opened this issue Oct 15, 2024 · 3 comments
Labels
upkeep maintenance, infrastructure, and similar

Comments

@maelle
Copy link
Contributor

maelle commented Oct 15, 2024

"This will not work in future igraph versions"

should we make this an error then?!

@maelle maelle changed the title warning in iterators.R warnings in iterators.R Oct 15, 2024
@maelle
Copy link
Contributor Author

maelle commented Oct 15, 2024

also:

"This will not work in future igraph versions"

@szhorvat
Copy link
Member

Let's think this through calmly at some point in the future.

Naively, I'm thinking that sometimes several different graphs have the same vertex set. For example, G2 may have been obtained from G1 by deleting some edges. One one may have a subset of the vertices of the other.

We need to support this use case gracefully.

Since I won't work in R regularly, I can't tell if this is already support well (although I suspect it is), and whether it has an impact on this issue (I suspect it does not).

@maelle maelle added the upkeep maintenance, infrastructure, and similar label Oct 15, 2024
@maelle
Copy link
Contributor Author

maelle commented Oct 15, 2024

Thank you! Yep, no hurry, I saw this as I'm converting warnings to a nicer interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upkeep maintenance, infrastructure, and similar
Projects
None yet
Development

No branches or pull requests

2 participants