New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve top-level code in tests #1082

Open

maelle opened this issue Jan 8, 2024 · 0 comments

Labels

upkeep

Milestone

Contributor

maelle commented Jan 8, 2024

For instance at the top of test-indexing there are two helper functions with names so short I find them unclear.

For top level code

rename helper functions, save them in tests/testthat/helper- files
move it to inside the tests.

maelle added the upkeep label

maelle mentioned this issue

test: remove top-level code in test-indexing.R #1085

Merged

krlmlr added this to the upkeep milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment