Update android.junit5 to v2 (major)

[renovate]

This PR contains the following updates:

Package	Change	Age	Confidence
de.mannodermaus.android-junit5	1.14.0.0 → 2.0.0
de.mannodermaus.gradle.plugins:android-junit5	1.14.0.0 → 2.0.0

---

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.

---

• If you want to rebase/retry this PR, check this box

---

This PR was generated by Mend Renovate. View the repository job log.

[claude]

Pull Request Review: Update android.junit5 to v2 (major)

Summary

This PR updates the android-junit5 Gradle plugin from version 1.14.0.0 to 2.0.0, representing a major version bump. The change affects both the plugin reference and the Gradle plugin dependency in the build-logic module.

---

Code Quality & Best Practices ✅

Positive aspects:

• Clean, minimal change - single line update in version catalog
• Follows the project's dependency management conventions using the version catalog pattern
• The plugin is declared consistently in both libs.versions.toml references (plugin and gradlePlugin)

Observations:

• The change is appropriately isolated to the version catalog, demonstrating good centralized dependency management
• No direct code changes required in application code, indicating good abstraction

---

Potential Issues & Concerns ⚠️

Major version upgrade risks:

1. Breaking changes not verified - This is a major version upgrade (1.x → 2.x), which typically includes breaking changes. However, I could not find:

   • Migration guide verification
   • Release notes review for breaking changes
   • Explicit testing of the upgrade path

2. Plugin usage is indirect - The junit5-android plugin is:

   • Declared in the root build.gradle.kts as apply false (gradle/libs.versions.toml:66, build.gradle.kts:16)
   • Included as a dependency in build-logic/build.gradle.kts (line 35)
   • BUT: I could not find where it's actually applied to any module
   • The project uses JUnit Jupiter via the TestConventionPlugin which configures useJUnitPlatform() but doesn't explicitly apply the android-junit5 plugin

3. Potential unused dependency - The plugin appears to be:

   • Declared and included in dependencies
   • Not actively applied in any convention plugin (ApplicationConventionPlugin, FeatureConventionPlugin, LibraryConventionPlugin, TestConventionPlugin)
   • Tests are running with JUnit Jupiter using useJUnitPlatform() configuration

---

Test Coverage 🧪

Current test setup:

• Tests use JUnit Jupiter API (org.junit.jupiter:junit-jupiter-api:6.0.1)
• TestConventionPlugin configures all Test tasks to use useJUnitPlatform()
• Test bundle includes: junit-jupiter-api, junit-jupiter-engine, junit-platform-launcher
• Feature modules and library modules inherit test configuration via convention plugins

Recommendation:

• Verify that the android-junit5 plugin v2 is actually needed
• If it is needed, ensure it's being applied somewhere (I couldn't locate the application point)
• Run the full test suite to verify compatibility: ./gradlew test -x konsist-test:test
• Run konsist tests separately: ./gradlew konsist-test:test

---

Performance Considerations ⚡

Neutral impact expected:

• Plugin version updates typically don't affect runtime performance
• Build-time impact should be minimal
• The plugin is used during test execution configuration only

---

Security Concerns 🔒

Low risk:

• Update comes from the official mannodermaus/android-junit5 repository
• Dependency is a build-time/test-time plugin, not included in production APK
• No known security vulnerabilities in either version

---

Recommendations

Before merging:

1. Verify plugin is actually used - Confirm whether the android-junit5 plugin is actively being used in the project, or if it's a legacy dependency that can be removed

2. Review migration guide - Check the android-junit5 v2.0.0 release notes for:

   • Breaking changes
   • Migration steps
   • Deprecated features
   • New requirements

3. Test verification - Ensure all test suites pass:

   ./gradlew clean test --rerun-tasks
   ./gradlew konsist-test:test --rerun-tasks

4. Consider adding to Known Issues - If there are any compatibility issues discovered, document them in DeveloperReadme.md following the existing pattern

5. Verify CI pipeline - Ensure all GitHub Actions checks pass, particularly:

   • unit-test job
   • konsist job

---

Conclusion

This is a straightforward dependency update from a maintenance perspective, but requires verification due to the major version bump. The main concern is ensuring there are no breaking changes that affect the test infrastructure.

Recommendation: Request that tests be run and verified before merging. If tests pass without modification, this change is safe to merge.

Priority: Medium - Not urgent, but should be merged once verified to stay current with dependency updates.

[claude]

PR Review: Update android.junit5 to v2 (major)

Summary

This PR updates the android-junit5 plugin from version 1.14.0.0 to 2.0.0 (major version bump). The change is minimal - updating a single version in the Gradle version catalog.

---

Code Quality & Best Practices ✅

Positive:

• The change follows the repository's dependency management pattern using the version catalog
• Clean, minimal change to gradle/libs.versions.toml
• Both plugin and library reference use the same version variable, maintaining consistency

Observations:

• The plugin is declared in the root build.gradle.kts with apply false (line 16)
• The plugin is included in build-logic/build.gradle.kts as a dependency (line 35)
• However, I don't see the plugin being explicitly applied (de.mannodermaus.android-junit5) in any of the convention plugins

Question:
Is the de.mannodermaus.android-junit5 plugin actually being applied anywhere in the project? I see that:

• TestConventionPlugin uses useJUnitPlatform() which enables JUnit 5 support
• Test modules include JUnit Jupiter dependencies
• But the android-junit5 Gradle plugin itself doesn't appear to be applied in any convention plugin

If the plugin isn't being used, this might still be a valid dependency update for the gradle plugin library, but it would be worth clarifying whether the plugin is needed.

---

Potential Issues & Breaking Changes ⚠️

Major Version Considerations:

1. Breaking Changes: As a major version update (v1.x → v2.x), there may be breaking changes. I cannot verify the release notes without web access, but major versions typically include:

   • API changes
   • Configuration changes
   • Minimum requirement updates (Gradle, AGP, Kotlin versions)

2. Testing Required:

   • Verify all unit tests still pass: ./gradlew test
   • Check for any deprecation warnings or errors during build
   • Confirm test execution reports are generated correctly

3. Compatibility Check: Ensure compatibility with current versions:

   • Kotlin: 2.3.0
   • AGP: 8.13.2
   • Gradle: (should verify wrapper version)

---

Performance Considerations ✅

Neutral Impact:

• Version updates to Gradle plugins typically have minimal runtime performance impact
• Build performance impact should be negligible
• Test execution performance may improve if v2.0.0 includes optimizations

---

Security Concerns ✅

Low Risk:

• The update comes from the official mannodermaus/android-junit5 repository
• Renovate bot has verified the package source
• Updating to newer versions generally improves security posture
• No direct security vulnerabilities identified in test infrastructure dependencies

---

Test Coverage 📋

Current State:

• The project has comprehensive unit test coverage across feature modules
• Tests use JUnit Jupiter (JUnit 5) APIs correctly
• useJUnitPlatform() is configured in TestConventionPlugin

Recommendations:

1. Run full test suite before merging:

   ./gradlew test --continue

2. Verify test execution for all modules:

   • feature:album
   • feature:settings
   • konsist-test
   • All other modules with tests

3. Check CI pipeline to ensure all automated tests pass

---

Migration Checklist

Before merging, please verify:

• Run ./gradlew test --continue to ensure all tests pass
• Review android-junit5 v2.0.0 release notes for breaking changes
• Check for any new deprecation warnings during build
• Verify test reports are generated correctly
• Confirm CI pipeline passes all checks
• If there are breaking changes, update convention plugins accordingly

---

Overall Assessment

Recommendation: ✅ Approve with verification

This is a clean, well-structured dependency update following repository conventions. The main concerns are:

1. Verify the plugin is actually being used - if it's not applied anywhere, consider whether it's needed
2. Test thoroughly - major version updates can introduce breaking changes
3. Review release notes - understand what changed in v2.0.0

The change itself is low-risk and follows best practices. Once testing confirms everything works correctly, this should be safe to merge.

---

Great work on keeping dependencies up to date! 🚀

[claude]

Pull Request Review: Update android.junit5 to v2 (major)

Overview

This PR updates the android-junit5 plugin from version 1.14.0.0 to 2.0.0, which is a major version update.

---

Code Quality and Best Practices ✅

The change itself is minimal and well-scoped:

• Single version number update in gradle/libs.versions.toml
• No unnecessary changes or scope creep
• Clean, focused dependency update

---

Potential Issues and Breaking Changes ⚠️

As this is a major version bump, there may be breaking changes that need investigation:

1. Missing Plugin Application: I noticed that while the junit5-android plugin is defined in the version catalog (line 66 of libs.versions.toml), I couldn't find where it's being applied in the build files. The project uses:

   • TestConventionPlugin which calls useJUnitPlatform()
   • JUnit Jupiter dependencies in the test bundle
   • But the de.mannodermaus.android-junit5 plugin doesn't appear to be applied anywhere

   Action Required: Verify whether the plugin needs to be explicitly applied somewhere, or if this is intentional.

2. Breaking Changes Research Needed: Since this is a major version update (v1 → v2), you should:

   • Check the android-junit5 release notes for v2.0.0
   • Look for migration guides or breaking changes documentation
   • Verify compatibility with current Kotlin version (2.3.0) and Gradle (8.13.2)

3. Dependency Verification: The version is referenced in two places:

   • gradle/libs.versions.toml:49 - version declaration
   • gradle/libs.versions.toml:66 - plugin alias
   • gradle/libs.versions.toml:79 - gradle plugin library

   All references use the same version ref, which is correct ✅

---

Test Coverage 🧪

Current Test Setup:

• All test files use JUnit Jupiter (org.junit.jupiter.api.Test)
• Tests are configured with useJUnitPlatform() in TestConventionPlugin:17
• Test bundle includes: junit-jupiter-api, junit-jupiter-engine, junit-platform-launcher
• Parallel test execution is enabled via system properties

Recommendations:

1. Run the full test suite after this update to verify compatibility:

   ./gradlew test --rerun-tasks

2. Check specific test modules:

   ./gradlew :feature:album:test
   ./gradlew :konsist-test:konsist-test
   ./gradlew :library:test-utils:test

3. Verify CI passes before merging to ensure all tests execute successfully in the CI environment

---

Performance Considerations ⚡

• No performance impact expected from this version update
• The plugin itself is build-time only
• Test execution performance may improve if v2.0.0 includes optimizations

---

Security Concerns 🔒

No security concerns identified:

• This is a well-maintained, reputable plugin from the Android community
• Major version updates typically include security patches
• Dependency is test-scoped only (no runtime impact)

---

Recommendations Summary

Before Merging:

1. ✅ Verify the plugin is being applied correctly (or if it's needed at all)
2. ✅ Review the v2.0.0 release notes and migration guide
3. ✅ Run the full test suite locally: ./gradlew test
4. ✅ Ensure CI checks pass completely
5. ✅ Consider testing on a feature branch first if any breaking changes are documented

Additional Context:

• The project uses JUnit Jupiter 6.0.2 which should be compatible
• AGP version 8.13.2 is recent and should support the updated plugin
• No test code changes appear necessary based on current implementation

---

Overall Assessment: This appears to be a straightforward dependency update, but requires verification due to the major version bump. Please ensure all tests pass and check for any documented breaking changes before merging.