Fix response header splitting to allow double CRLF in response body

Author: igorw

CHANGELOG.md

@@ -0,0 +1,7 @@
+### 1.0.1 (2013-03
+
+  * Bugfix: Allow double CRLF in response body
+
+### 1.0.0 (2013-03-11)
+
+  * Initial release

src/Igorw/CgiHttpKernel/CgiHttpKernel.php

@@ -67,7 +67,7 @@ public function handle(Request $request, $type = HttpKernelInterface::MASTER_REQ
         $process->start();
         $process->wait();
 
-        list($headerList, $body) = explode("\r\n\r\n", $process->getOutput());
+        list($headerList, $body) = explode("\r\n\r\n", $process->getOutput(), 2);
         $headers = $this->getHeaderMap(explode("\r\n", $headerList));
         unset($headers['Cookie']);
 

tests/functional/CgiHttpKernelTest.php

@@ -248,4 +248,14 @@ public function attributesShouldBeSerializedToEnv()
         $expected = json_encode($attributes);
         $this->assertSame($expected, $response->getContent());
     }
+
+    /** @test */
+    public function doubleCrlfResponseBodyShouldBeDecodedProperly()
+    {
+        $request = Request::create('/double-crlf-response-body.php');
+        $response = $this->kernel->handle($request);
+
+        $expected = "foo\r\n\r\nbar";
+        $this->assertSame($expected, $response->getContent());
+    }
 }

tests/functional/Fixtures/double-crlf-response-body.php

@@ -0,0 +1,3 @@
+<?php
+
+echo "foo\r\n\r\nbar";