-
-
Notifications
You must be signed in to change notification settings - Fork 18
Feat/config terminal split #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
When terminal position "left" dap uses |
…f to "useopen" to prevent terminal window from being used for goto breakpoint
3d78a12 to
b8a3868
Compare
…view window from being used for breakpoint focusing
I can see this being troublesome. For now, I think the terminal position should suffice. |
|
Hey there! I just pushed a commit to main that enables a basic type validation for the config. Can you also add that here? It should be somewhat straightforward. Besides checking that the type is in fact a string, we can add a "semantics" check to ensure it's either |
chore: resolve merge conflicts with main ref: removes dep switchbuf fallback setting fix: removes trailing comma
9a7605d to
4d72e34
Compare
igorlfs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a minor, but important thread. Thanks for the patience!

Perhaps instead of configuring terminal position, we can just provide a list of window ordering, left to right:
{"views", "terminal"}