Skip to content

Conversation

@catgoose
Copy link
Contributor

  • Allows setting terminal position (left or right) when creating window layout
  • Creates window.terminal config key to allow for future terminal configuration

image

Perhaps instead of configuring terminal position, we can just provide a list of window ordering, left to right:

{"views", "terminal"}

@catgoose
Copy link
Contributor Author

using windows.terminal.position="right" replaces REPL when using terminal and breakpoint is hit:

image

I'll look at this later.

@catgoose
Copy link
Contributor Author

When terminal position "left" dap uses switchbuf global setting which defaults to lastopen If you focus view window before terminal window, interact with terminal so a breakpoint is hit, the view window would be used for breakpoint. Setting dap.defaults.fallback.switchbuf = "useopen" forces main window to be used for showing breakpoint.

…f to "useopen" to prevent terminal window from being used for goto breakpoint
@catgoose catgoose force-pushed the feat/config_terminal_split branch from 3d78a12 to b8a3868 Compare January 26, 2025 03:51
@igorlfs
Copy link
Owner

igorlfs commented Feb 5, 2025

Perhaps instead of configuring terminal position, we can just provide a list of window ordering, left to right:

I can see this being troublesome. For now, I think the terminal position should suffice.

@igorlfs
Copy link
Owner

igorlfs commented Feb 9, 2025

Hey there! I just pushed a commit to main that enables a basic type validation for the config. Can you also add that here? It should be somewhat straightforward. Besides checking that the type is in fact a string, we can add a "semantics" check to ensure it's either "right" or "left".

chore: resolve merge conflicts with main

ref: removes dep switchbuf fallback setting

fix: removes trailing comma
@catgoose catgoose force-pushed the feat/config_terminal_split branch from 9a7605d to 4d72e34 Compare February 12, 2025 01:48
Copy link
Owner

@igorlfs igorlfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a minor, but important thread. Thanks for the patience!

@igorlfs igorlfs merged commit 273bcde into igorlfs:main Feb 13, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants