fix(DapViewWatch): switch to Watcher view when repl active #8
+11
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…witch to Watcher view
igorlfs
requested changes
Jan 24, 2025
Owner
igorlfs
left a comment
igorlfs
left a comment
There was a problem hiding this comment.
Thanks for your contribution! Left a comment, LMK what you think
igorlfs
reviewed
Jan 25, 2025
igorlfs
approved these changes
Jan 26, 2025
| require("dap-view.views").switch(function() | ||
| require("dap-view.breakpoints.view").show() | ||
| end) | ||
| require("dap-view.views").switch(require("dap-view.breakpoints.view").show) |
igorlfs
pushed a commit
that referenced
this pull request
Jan 29, 2025
* fix: when using DapViewWatch on current position with repl showing, switch to Watcher view * ref: use nvim_set_current_buf to set buffer for winnr * ref(watcher): when adding watcher expression check if window is valid before switching view * ref: add window id checks when switching views * ref: removes redundant function wraps for callback argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue where when using
DapViewWatchif repl is active the Watcher view does not get filled with watcher expressions