feat: watches rewrite #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igorlfs
force-pushed
the
feat/watches-rewrite
branch
from
1910fa8 to
27f94c4
Compare
igorlfs
force-pushed
the
feat/watches-rewrite
branch
from
19f29f7 to
9b6335c
Compare
top level variables improve handling of errors refactor: no need for stopped_thread_id state feat: colors, handle deleting expressions feat: edit expressions refactor: simplify implementation by indexing with strings The downside is that the ordering is kinda awkward, but that's fine by me feat: update and highlight changed expressions refactor(watches): cleaner eval variables feat: allow collapsing via foldmethod = indent feat: copy expression to clipboard chore: appease type checker feat(watches): highlight updated variables some fixes for keymaps chore: add type annotation update docs
igorlfs
force-pushed
the
feat/watches-rewrite
branch
2 times, most recently
from
b3221d9 to
277be0c
Compare
igorlfs
force-pushed
the
feat/watches-rewrite
branch
from
277be0c to
058e34d
Compare
Owner
Author
Besides the folding situation, nvim-dap's presentation is slightly different. For instance, it uses |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #33
Preview
Drawbacks
<CR>can be used for both collapsing and expanding, which is something I currently have no idea how to do. Might figure this out, but I've been thinking about upstreaming this feature (if appropriate), so this wouldn't be an issue. Also, indent-based collapsing isn't as cool as the alternative.copy=>Can't copy variables. That's no biggie, I guess, since now we can properly move around and copy them directlyvariables aren't highlighted when their value change, only expressions. I think this would be somewhat annoying to implement, so leaving it out from this initial implementationDoneFollow-up
Tracked by #33.