feat: expose terminal bufnr/winnr in state module

[catgoose]

allows for creating terminal window before dap session has started

Addresses #18

I'm not sure about storing the terminal bufnr/winnr state in the terminal module, maybe we can store it in state module? I just needed some way to get bufnr out of the plugin after opening nvim-dap-view

[igorlfs]

maybe we can store it in state module?

Yeah, if we proceed with this change, I think it's better to store these variables in the state module.

[igorlfs]

Remember to add the new option to the default config in the README.

I'm a bit wary of adding yet another option to control the terminal. The major issue is that it's not clear how this setting should behave when other settings are enabled. For instance: should hide take precedence over ignore_session? I'm fine with either behavior, but this should be documented, as to not give users any surprises.

[catgoose]

maybe we can store it in state module?

Yeah, if we proceed with this change, I think it's better to store these variables in the state module.

I am in no rush to merge this PR because I want to do a bit of testing to make sure everything is good, but I will address your comments.

[catgoose]

Remember to add the new option to the default config in the README.

I'm a bit wary of adding yet another option to control the terminal. The major issue is that it's not clear how this setting should behave when other settings are enabled. For instance: should hide take precedence over ignore_session? I'm fine with either behavior, but this should be documented, as to not give users any surprises.

Yeah of course, I understand. I'll test different configurations to make sure this doesn't conflict with the other terminal settings.

[catgoose]

Ok it seems that I can make this work without the bootstrap option. Using this configuration after 92010f2:

    opts = {
      winbar = {
        show = true,
        sections = { "watches", "breakpoints", "repl" },
        default_section = "breakpoints",
      },
      windows = {
        height = 12,
        terminal = {
          position = "right",
          -- hide = { "go" },
          start_hidden = true,
        },
      },
    },

If I use start_hidden = false, some weird jumping occurs, but start_hidden = true operates the same as the bootstrap configuration.

In summary what we had to do was make the term bufnr and winnr available in state module and do that nil check on previous adapter in events.

By the way it seems that there is a go and delve adapters: https://github.com/mfussenegger/nvim-dap/wiki/Debug-Adapter-installation#Go

[igorlfs]

Hey! I'm glad you managed to make it work without having to introduce another option!

By the way it seems that there is a go and delve adapters

I've never written a single line of Go in my life, so I'm not really well versed with the language. But if you feel this belongs into the README example, go ahead!

[catgoose]

Hey! I'm glad you managed to make it work without having to introduce another option!

By the way it seems that there is a go and delve adapters

I've never written a single line of Go in my life, so I'm not really well versed with the language. But if you feel this belongs into the README example, go ahead!

I think from reading that link that it would be more correct to reference go rather than delve. But in any case the user would be able to add whatever adapters they need to the hide table.

[igorlfs]

I think from reading that link that it would be more correct to reference go rather than delve

Either way is fine by me ^^

[igorlfs]

Hm, oddly this is breaking my setup, which uses pretty much a default config :/

[igorlfs]

As is turns out, this line actually breaks the "standard" use case. If you first open a ndv's main window and then try to start a session, the terminal will be spawned on top of ndv's main a window (an additional split is also created). Perhaps we DO have to introduce an option for your use case!

For now, I'm reverting this change.

[catgoose]

Alright, I'll try to recreate that issue and see what I can do in another PR.

[catgoose]

Sorry I cannot reproduce. I am using the basic go debug adapter without my special magic, and for nvim-dap-view: no config overrides, open with DapViewOpen or require("dap-view").toggle(true), start debugger and it looks right:

Perhaps it's something with your debug adapter (or mine)? Can you post a screenshot of what is happening?

[igorlfs]

Hey! Sorry, for the past few days, my main concern was getting the stacks + threads view working!

For the reproduction, I'm also using the default options, but I'm using debugpy. I believe this is issue is actually being caused by how debugpy handles multiple sessions, though I haven't been able to confirm that. Can you try using debugpy to check if you can reproduce?

If this turns out to be an issue with debugpy, I'm not sure how to best handle the situation.

[igorlfs]

As is turns out, this line actually breaks the "standard" use case. If you first open a ndv's main window and then try to start a session, the terminal will be spawned on top of ndv's main a window (an additional split is also created). Perhaps we DO have to introduce an option for your use case!

I have no idea how I was observing this behavior. Seriously. Perhaps I had some uncommited change, which was interfering? No idea. I'm sorry for the trouble!

I'll be reverting the revert once I'm done with another portion of my refactoring.