feature: Add a new terminal tab to open new terminal.

[231tr0n]

Did you check the docs?

• I have read all the docs

Is your feature request related to a problem? Please describe.

Hi igorlfs. Is it possible to add a new terminal pane to the UI just like how VSCode does. The reason why I am asking this is that I generally debug by starting a remote server. So, in that case I will have to open a terminal to do it. I taught it would be better if nvim-dap-view provides a terminal integrated with other windows which could be really helpful.

Describe the solution you'd like

Add a terminal view

Describe alternatives you've considered

None

Additional context

None

[igorlfs]

Hello!

So, in that case I will have to open a terminal to do it.

Is there a dealbreaker with :term? For me, it works perfectly. As an example, in my workflow, I usually open a new tab, use :term and run the command to launch a server.

Is it possible to add a new terminal pane to the UI just like how VSCode does.

AFAIK, the way VSCode exposes the terminal is not standardized in the protocol. You may not be referring to that specifically, but in VSCode it's possible to start a debugging session directly from within the terminal, via the node-terminal adapter (for instance). IMO, a really nice feature. But, as I mentioned, it isn't standardized. See this issue (and the issue it links) for context.

So, if I were to add a terminal view, it wouldn't be any different from a regular :term, which I think makes no sense for a plugin focused on the protocol. However, if you're unsatisfied with using :term, we could build a way to add custom views, allowing you to embed a terminal view yourself. We already have a similar mechanism for the control bar. What do you think?

[231tr0n]

Hello!

So, in that case I will have to open a terminal to do it.

Is there a dealbreaker with :term? For me, it works perfectly. As an example, in my workflow, I usually open a new tab, use :term and run the command to launch a server.

Is it possible to add a new terminal pane to the UI just like how VSCode does.

AFAIK, the way VSCode exposes the terminal is not standardized in the protocol. You may not be referring to that specifically, but in VSCode it's possible to start a debugging session directly from within the terminal, via the node-terminal adapter (for instance). IMO, a really nice feature. But, as I mentioned, it isn't standardized. See this issue (and the issue it links) for context.

So, if I were to add a terminal view, it wouldn't be any different from a regular :term, which I think makes no sense for a plugin focused on the protocol. However, if you're unsatisfied with using :term, we could build a way to add custom views, allowing you to embed a terminal view yourself. We already have a similar mechanism for the control bar. What do you think?

@igorlfs so the thing is I have a function to toggle terminal in a below right split to start delve server in remote debug mode to see output and I open nvim-dap-view. They open one on top of another. That is the exact issue I am facing. So I taught it would be good if I could embed the terminal in nvim-dap-view window itself. That was the intention behind this request.

We could build a way to add custom views, allowing you to embed a terminal view yourself. We already have a similar mechanism for the control bar. What do you think?

This is fine as well. If there is some mechanism provided to add a terminal window to the UI.
So vscode has the bottom pane for showing diagnostics, terminal, and everything with multiple tabs you can toggle. That was what I was mentioning.

[igorlfs]

@igorlfs so the thing is I have a function to toggle terminal in a below right split to start delve server in remote debug mode to see output and I open nvim-dap-view. They open one on top of another. That is the exact issue I am facing. So I taught it would be good if I could embed the terminal in nvim-dap-view window itself. That was the intention behind this request.

I see, so that's basically #18? I'm not really a Go guy, but if you share the minimum setup (with files, configuration, etc), I can take a look. But beware that the way terminals work will change to support multiple sessions (see #50), so this may be put on hold until that's done.

I actually took a peek at your config and, by the way, it's no longer necessary to use ---@diagnostic disable-next-line: missing-fields ^^

[231tr0n]

@igorlfs so the thing is I have a function to toggle terminal in a below right split to start delve server in remote debug mode to see output and I open nvim-dap-view. They open one on top of another. That is the exact issue I am facing. So I taught it would be good if I could embed the terminal in nvim-dap-view window itself. That was the intention behind this request.

I see, so that's basically #18? I'm not really a Go guy, but if you share the minimum setup (with files, configuration, etc), I can take a look. But beware that the way terminals work will change to support multiple sessions (see #50), so this may be put on hold until that's done.

I actually took a peek at your config and, by the way, it's no longer necessary to use ---@diagnostic disable-next-line: missing-fields ^^

Hey btw the thing is that I rewrote all my configuration to work with remote debugging. So just a regular terminal embedded in nvim-dap-view should be more than enough for me. I will just start delve in remote debug mode in normal terminal inside nvim-dap-view once provided and attach to it.
If there is someway to add a terminal to nvim-dap-view that will get my job done.

[231tr0n]

I actually took a peek at your config and, by the way, it's no longer necessary to use ---@diagnostic disable-next-line: missing-fields ^^

Addressed this as well now. Thanks for notifying me.

[igorlfs]

Hey btw the thing is that I rewrote all my configuration to work with remote debugging. So just a regular terminal embedded in nvim-dap-view should be more than enough for me. I will just start delve in remote debug mode in normal terminal inside nvim-dap-view once provided and attach to it.

Can you share a basic Go setup I can use to take a better look at the situation? I'm thinking about natively supporting redirecting the IO

[231tr0n]

Hey btw the thing is that I rewrote all my configuration to work with remote debugging. So just a regular terminal embedded in nvim-dap-view should be more than enough for me. I will just start delve in remote debug mode in normal terminal inside nvim-dap-view once provided and attach to it.

Can you share a basic Go setup I can use to take a better look at the situation? I'm thinking about natively supporting redirecting the IO

@igorlfs if that is what you want I can share detailed steps on it for sure but the thing is all I need is a way to attach a normal terminal to dap-view ui since I start all my debug configs in remote only?

I will make sure to share this in the evening IST today

[231tr0n]

package main

import "fmt"

func main() {
  fmt.Println("test")
  fmt.Println("test")
}

Put this in a file named main.go.

nvim-dap adapter configuration

	dap.adapters.delve = function(callback, config)
		callback({
			type = "server",
			hostName = config.hostName,
			port = config.port,
		})
	end

nvim-dap debug configuration

	dap.configurations.go = {
		{
			type = "delve",
			name = "Attach remote",
			mode = "remote",
			request = "attach",
			outputMode = "remote",
			hostName = function()
				return Global.input_helper("Enter host: ", "127.0.0.1")
			end,
			port = function()
				return Global.input_helper("Enter port: ", 38697)
			end,
		},
	}

Start the delve dap server using the following command

dlv debug --headless -l 127.0.0.1:38697 main.go

Connect to the dap server by starting dap and selecting this config altough since it is only one config it is selected by default.

This sums up the setup.

Go toolchain and delve debugger have to be installed for this to work.