Unable to use default_section = "console"

[Run1e]

Not being able to use "console" as the default_section leads to this unfortunate workflow each time your start a session:

1. Start a new debug session
2. Press your keymap to open nvim-dap-view
3. Press C to open the console
4. Press G to make the console window follow the output

And since the terminal buffer disappears when the session ends, which also closes nvim-dap-view, the aforementioned steps need to be repeated each time your restart.

Improvements would make usage a lot more ergonimic:

1. Make it possible to use "console" as the default section
2. Automatically follow output when a session starts (or when opening the console section? not sure)

[igorlfs]

leads to this unfortunate workflow each time your start a session

This was happening because of a bug in the autoscroll logic. Can you pull the latest changes from #108 and check again?

Make it possible to use "console" as the default section

I'll check if allowing that when a session is running does not introduce any funny behavior... But if no session is running, there's nothing to display on the console, so this doesn't really make sense? To be fair, many other views don't make any sense when there's no session, but they are shown anyway. So I updated the console view to be just like that with the latest commit to #108, c89945d.

From my initial testing, everything looks fine. Let me know if I missed anything.

[igorlfs]

Let me know if I missed anything.

Testing today at work, I noticed several bugs (mostly with hidden adapters). 🤔

[Run1e]

Unfortunately still not having luck with the autoscroll on fix/83. Anything you want me to test?

[igorlfs]

Can you share more exact reproduction steps?

Here's a screencast with the scrolling working as intended when following

Start a new debug session
Press your keymap to open nvim-dap-view
Press C to open the console

scroll.mp4

I imagine at this stage it must be something in your config.

[Run1e]

It was indeed something in my config, sorry for sending you on a goose chase!

I have some wrapper stuff that makes it so that I can toggle between nvim-dap-view and toggleterm easily, and while that's a lot of code I found that a call to vim.api.nvim_set_current_win right after opening nvim-dap-view causes the autoscroll to break (this just auto-focuses the nvim-dap-view window after opening it).

Here's repro steps:

1. Set default_section = "console"
2. Start a session
3. Run this keybind to open nvim-dap-view:

		vim.keymap.set("n", "<leader>do", function()
			local actions = require("dap-view.actions")
			local state = require("dap-view.state")

			actions.open()
			vim.api.nvim_set_current_win(state.winnr)
		end, { desc = "DAP: Toggle dap-view" })

4. The console will not autoscroll

Commenting out the vim.api.nvim_set_current_win call makes it work again.

E: I also see you merged fix/83, and this still happens on current main.
E2: also, this is obviously not my actual keymap I use, just a minimal repro keymap :)
E3: if it's because the focusing is happening in the wrong order after something in actions.open(), maybe a focus_on_open option and make actions.open() do it where it makes most sense?

[igorlfs]

Hey, sorry, had a busy week.

I can toggle between nvim-dap-view and toggleterm easily

Can you explain your use case a bit better? I'm thinking an alternative would be using an anchor function for toggleterm's win. Not quite a "switch between dap and term", but it might be close enough for you. Regardless, I'll investigate with the minmal code you provided. One note though: avoid manipulating nvim-dap-view's internal state, it's prone to breaking changes without notice.

if it's because the focusing is happening in the wrong order after something in actions.open(), maybe a focus_on_open option and make actions.open() do it where it makes most sense?

There's a jump_to_view function in the API. It might suffice for your use case. We could make it so that if nil is passed, the last view will take focus, so that you don't have to retrieve it.

Edit: jump_to_view seems to be working fine. Can you give it a try?

[Run1e]

Can you explain your use case a bit better?

It's unrelated to this issue, but the gist is that I don't want my terminal (toggleterm) window and the nvim-dap-view window to be visible at the same time. To achieve this, I've wrapped your actions.open and if my terminal is open when its called it closes it first before opening nvim-dap-view, and the other way around (opening terminal closes nvim-dap-view).

That said, I took a look and found the issue. The issue occurs when you focus on the nvim-dap-view terminal before any output. When this happens, the CursorMoved autocmd runs, and since the buf line count is the height of the terminal window (in my case 15) and the cursor position is 1, autoscroll is set to false. Then when the first line of output arrives, the on_lines handler doesn't autoscroll.

PR at #111

[igorlfs]

Hey, sorry for taking a while!

PR at #111

Just left a review there!

[igorlfs]

The original concerns of this discussion have been addressed