feat: improve multitab support

Previously, toggling ndv would be a noop if it was opened on another tab
(it would close that instance with no effect on the current tab). That
means you had to toggle twice for it to show up, which is lame.

To handle that, we can track the windows instances only for the current
tab. There are some downsides, which could be addressed with "proper"
multitab support (having ndv actually show up in multiples tabs at
once), but tracking state gets cumbersome.

Author: igorlfs

docs/src/posts/api.md

@@ -8,7 +8,7 @@ The API offer the same functionality as the [commands](commands).
 require("dap-view").open()
 ```
 
-Opens both `nvim-dap-view` windows: views + console.
+Opens both `nvim-dap-view` windows[^1]: views + console.
 
 ---
 
@@ -54,3 +54,5 @@ require("dap-view").show_view(view)
 ```
 
 Shows a given view. If the specified view is already the current one, jumps to its window.
+
+[^1]: In the current tab. May close the views window in another tab.

docs/src/posts/commands.md

@@ -6,7 +6,7 @@ Commands offer the same functionality as the [API](api).
 
 ## `DapViewOpen`
 
-Opens both `nvim-dap-view` windows: views + console.
+Opens both `nvim-dap-view` windows[^1]: views + console.
 
 ## `DapViewClose`
 
@@ -27,3 +27,5 @@ Shows a given view and jumps to its window. For instance, to jump to the REPL, y
 ## `DapViewShow [view]`
 
 Shows a given view. If the specified view is already the current one, jumps to its window.
+
+[^1]: In the current tab. May close the views window in another tab.

lua/dap-view.lua

@@ -1,4 +1,5 @@
 require("dap-view.highlight")
+require("dap-view.autocmds")
 -- Connect hooks to listen to DAP events
 require("dap-view.events")
 

lua/dap-view/autocmds.lua

@@ -0,0 +1,45 @@
+local state = require("dap-view.state")
+local winbar = require("dap-view.options.winbar")
+
+local api = vim.api
+
+api.nvim_create_autocmd("TabEnter", {
+    callback = function()
+        local winnr = nil
+        local term_winnr = nil
+
+        for _, win in ipairs(api.nvim_tabpage_list_wins(0)) do
+            local bufnr = api.nvim_win_get_buf(win)
+            local ft = vim.bo[bufnr].filetype
+
+            if ft == "dap-view" then
+                if winnr == nil then
+                    winnr = win
+                end
+            end
+
+            if ft == "dap-view-term" then
+                if state.current_section == "console" then
+                    if winnr == nil then
+                        winnr = win
+                    end
+                elseif term_winnr == nil then
+                    term_winnr = win
+                end
+            end
+
+            if ft == "dap-repl" and state.current_section == "repl" then
+                if winnr == nil then
+                    winnr = win
+                end
+            end
+        end
+
+        state.winnr = winnr
+        state.term_winnr = term_winnr
+
+        if winnr ~= nil then
+            winbar.show_content(state.current_section)
+        end
+    end,
+})

lua/dap-view/breakpoints/view.lua

@@ -13,7 +13,7 @@ local api = vim.api
 M.show = function()
     winbar.update_section("breakpoints")
 
-    if state.bufnr then
+    if state.bufnr and state.winnr then
         local breakpoints = vendor.get()
 
         local line = 0

lua/dap-view/exceptions/view.lua

@@ -12,7 +12,7 @@ local api = vim.api
 M.show = function()
     winbar.update_section("exceptions")
 
-    if state.bufnr then
+    if state.bufnr and state.winnr then
         local cursor_line = api.nvim_win_get_cursor(state.winnr)[1]
 
         if views.cleanup_view(not dap.session(), "No active session") then

lua/dap-view/threads/actions.lua

@@ -12,15 +12,17 @@ M.jump_or_noop = function()
     local line = vim.fn.getline(".")
 
     if string.find(line, "\t") then
-        util.jump_to_location("^\t(.-)|(%d+)|")
-
         -- Set frame
         local cursor_line = api.nvim_win_get_cursor(state.winnr)[1]
         local frame = state.frames_by_line[cursor_line]
         if frame then
             local session = assert(dap.session(), "has active session")
             session:_frame_set(frame)
         end
+
+        -- Jump after switching the frame, since we need the state.winnr for the switch
+        -- (which could be missing after a jump)
+        util.jump_to_location("^\t(.-)|(%d+)|")
     else
         vim.notify("Can't jump to a thread", log.INFO)
     end

lua/dap-view/threads/view.lua

@@ -12,7 +12,7 @@ local api = vim.api
 M.show = function()
     winbar.update_section("threads")
 
-    if state.bufnr then
+    if state.bufnr and state.winnr then
         local session = dap.session()
         -- Redundant check to appease the type checker
         if views.cleanup_view(session == nil, "No active session") or session == nil then

lua/dap-view/views/init.lua

@@ -8,13 +8,13 @@ local api = vim.api
 ---@param cond boolean
 ---@param message string
 M.cleanup_view = function(cond, message)
-    if cond then
+    if cond and state.winnr then
         vim.wo[state.winnr][0].cursorline = false
 
         api.nvim_buf_set_lines(state.bufnr, 0, -1, false, { message })
 
         hl.hl_range("MissingData", { 0, 0 }, { 0, #message })
-    else
+    elseif state.winnr then
         vim.wo[state.winnr][0].cursorline = true
     end