feat(type): generate type with no crud operation #990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fadeev
previously approved these changes
Apr 16, 2021
ilgooz
reviewed
Apr 16, 2021
integration/cmd_type_test.go
Outdated
|
|
||
| env.Must(env.Exec("should prevent creating a legacy type with no message", | ||
| step.NewSteps(step.New( | ||
| step.Exec("starport", "type", "nomessagelegacy", "--no-message", "--legacy"), |
There was a problem hiding this comment.
Do we need to support -legacy at all?
There was a problem hiding this comment.
Because we still have --legacy option, I can remove this test now that we know we'll stop supporting this
fadeev
approved these changes
Apr 16, 2021
ilgooz
approved these changes
Apr 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #967
The flag
--no-messageallows to generate a type without interaction message.Queries are still generated.
To test:
In
msg_server_makefo.go:For templates the pattern is:
That can be discussed, this pattern would be used for other component like indexed type or packet