Skip to content

fix: don't run the linter on non code changes #817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2021
Merged

fix: don't run the linter on non code changes #817

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,17 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 6
steps:
- name: Set up Go
uses: actions/setup-go@v2
with:
go-version: "1.16"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.16 is the required version now for Starport. Should we rollback this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linter should be a prebuilt binary. You don't need to install go I believe

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with #819, seems like removing version is not a problem indeed. While we were using the alpha version of 1.16, it was somewhat required to manage Go installation ourselves because linter was not able to use non stable releases. I think the reason is the linter somehow uses go cmd under the hood or depends on a Go installation in some other way.


- uses: actions/checkout@v2

- uses: technote-space/get-diff-action@v4
with:
PATTERNS: |
**/**.go
go.mod
go.sum
- uses: golangci/golangci-lint-action@master
with:
version: v1.36.0
# Required: the version of golangci-lint is required and must be specified without patch version: we always use the latest patch version.
version: v1.37
args: --timeout 10m
github-token: ${{ secrets.github_token }}
skip-go-installation: true
if: env.GIT_DIFF