Skip to content

refactor(cosmosanalysis): proper message filtering #4686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 21, 2025
Merged

refactor(cosmosanalysis): proper message filtering #4686

merged 7 commits into from
May 21, 2025

Conversation

@julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented May 16, 2025 •
edited
Loading

Fixes the message filtering in cosmosanalysis.

@julienrbrt julienrbrt changed the title refactor(cosmosanalysis): keep only messages refactor(cosmosanalysis): proper message filtering May 16, 2025
@julienrbrt julienrbrt marked this pull request as ready for review May 16, 2025 14:16
@julienrbrt julienrbrt added the backport/v28.x.y Backport to v28.x.y label May 16, 2025
@clockworkgr
Copy link
Collaborator

clockworkgr commented May 19, 2025

Much better but it does not distinguish between send and return types leading to code generation for example for trying to broadcast a MsgSendResponse transaction simply because the MsgSendResponse message is used as a return type in an RPC service.

Is it possible to clear that up as well?

@clockworkgr clockworkgr mentioned this pull request May 20, 2025
Closed
7 tasks
@julienrbrt julienrbrt enabled auto-merge (squash) May 20, 2025 14:09
Pantani
Pantani approved these changes May 21, 2025
View reviewed changes
Copy link
Collaborator

@Pantani Pantani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@julienrbrt julienrbrt disabled auto-merge May 21, 2025 10:28
@julienrbrt julienrbrt merged commit 20a54d4 into main May 21, 2025
42 checks passed
@julienrbrt julienrbrt deleted the julien/hack branch May 21, 2025 10:30
mergify bot pushed a commit that referenced this pull request May 21, 2025
@julienrbrt @mergify
refactor(cosmosanalysis): proper message filtering (#4686)
843b205 
* refactor(cosmosanalysis): keep only messages

* updates

* simplify

* updates

* fix

* harden logic

(cherry picked from commit 20a54d4)
@mergify mergify bot mentioned this pull request May 21, 2025
Merged
julienrbrt added a commit that referenced this pull request May 21, 2025
@mergify @julienrbrt
refactor(cosmosanalysis): proper message filtering (backport #4686) (#…
8757361 
…4693)

* refactor(cosmosanalysis): proper message filtering (#4686)

* refactor(cosmosanalysis): keep only messages

* updates

* simplify

* updates

* fix

* harden logic

(cherry picked from commit 20a54d4)

* fixes

---------

Co-authored-by: julienrbrt <julien@rbrt.fr>
@julienrbrt julienrbrt mentioned this pull request May 30, 2025
Merged
@BrewTestBot BrewTestBot mentioned this pull request May 31, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Pantani Pantani Pantani approved these changes

@ilgooz ilgooz Awaiting requested review from ilgooz

@toschdev toschdev Awaiting requested review from toschdev

Assignees

@julienrbrt julienrbrt

Labels

backport/v28.x.y Backport to v28.x.y component:ci CI/CD workflow and automated jobs. component:configs component:packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@julienrbrt @clockworkgr @Pantani