build: switch dockerfile to go 1.23 #4517
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienrbrt
requested review from
Pantani,
ilgooz and
jeronimoalbi
as code owners
github-actions
bot
added
component:ci
laciferin2024
suggested changes
Feb 18, 2025
laciferin2024
left a comment
laciferin2024
left a comment
There was a problem hiding this comment.
Now that we have 1.24.0 released. lets support it
Member
Author
No, that's the reason the action wasn't working, because it was using 1.24.
|
Pantani
approved these changes
Feb 19, 2025
|
The CI is failing |
laciferin2024
approved these changes
Feb 19, 2025
laciferin2024
left a comment
laciferin2024
left a comment
There was a problem hiding this comment.
LGTM , minor changes. But do recommend you to give a go mod tidy
Member
Author
There is no go mod tidy required for a dockerfile 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #4516
This will be reverted in #4509