refactor: network release #2572
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilgooz
requested review from
Pantani,
fadeev,
ivanovpetr,
jeronimoalbi and
lumtis
as code owners
Pantani
approved these changes
Jun 9, 2022
lumtis
added a commit
that referenced
this pull request
Jul 29, 2022
* network connect cmd * rly commands * fetch client id from target chain * change connect logic order * find client state * network connect * remove comments and add TODO's * fetch client id from spn * improve the node client * fecth client id from the monitoring client package * avoid unecessary link * fix get path from relayer * add todo comment * pass session to the nodetime call log * change the client and channel queries * update spn version * update mock campaign queries * remove session from tsrelayer pkg * fix start relayer background job * change create client command to reward release * remove unused context InterfaceRegistry * fetch spn chain id from status * use the chain stake denom * remove duplicated method * fix channel id fetch for spn * add validation for already established and is missing in one of the chains * update spn * make RPC port public * make RPC port public * convert node into a private var for network * fix ibc-go version * refactor: network release (#2572) * fix methods and var names * fix import names * errorIs * remove unused id * refactor create client * simplify start * import * lint Co-authored-by: İlker G. Öztürk <ilkergoktugozturk@gmail.com> Co-authored-by: Petr Ivanov <petr.ivanov@tendermint.com> Co-authored-by: ltacker <lucas.bertrand.22@gmail.com>
Jchicode
pushed a commit
to Jchicode/cli
that referenced
this pull request
Aug 9, 2023
* network connect cmd * rly commands * fetch client id from target chain * change connect logic order * find client state * network connect * remove comments and add TODO's * fetch client id from spn * improve the node client * fecth client id from the monitoring client package * avoid unecessary link * fix get path from relayer * add todo comment * pass session to the nodetime call log * change the client and channel queries * update spn version * update mock campaign queries * remove session from tsrelayer pkg * fix start relayer background job * change create client command to reward release * remove unused context InterfaceRegistry * fetch spn chain id from status * use the chain stake denom * remove duplicated method * fix channel id fetch for spn * add validation for already established and is missing in one of the chains * update spn * make RPC port public * make RPC port public * convert node into a private var for network * fix ibc-go version * refactor: network release (ignite#2572) * fix methods and var names * fix import names * errorIs * remove unused id * refactor create client * simplify start * import * lint Co-authored-by: İlker G. Öztürk <ilkergoktugozturk@gmail.com> Co-authored-by: Petr Ivanov <petr.ivanov@tendermint.com> Co-authored-by: ltacker <lucas.bertrand.22@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.