fix: add missing light clients routes to IBC client keeper (#4587)

* fix: add missing routes to IBC client keeper

* add changelog

* remove unused scaffold code for relayer integration tests

* remove unused scaffold types and bump hermes app

* rollback removed changes

* bump relayer version

* use  random chain  name

Author: Pantani

changelog.md

@@ -17,6 +17,7 @@
 - [#4577](https://github.com/ignite/cli/pull/4577) Add proto version to query path.
 - [#4579](https://github.com/ignite/cli/pull/4579) Fix empty params response.
 - [#4585](https://github.com/ignite/cli/pull/4585) Fix faucet cmd issue.
+- [#4587](https://github.com/ignite/cli/pull/4587) Add missing light clients routes to IBC client keeper.
 
 ## [`v29.0.0-beta.1`](https://github.com/ignite/cli/releases/tag/v29.0.0-beta.1)
 

ignite/cmd/plugin_default.go

@@ -18,7 +18,7 @@ type defaultPlugin struct {
 const (
 	PluginNetworkVersion = "v0.2.2"
 	PluginNetworkPath    = "github.com/ignite/cli-plugin-network@" + PluginNetworkVersion
-	PluginRelayerVersion = "hermes/v0.2.4"
+	PluginRelayerVersion = "hermes/v0.2.8"
 	PluginRelayerPath    = "github.com/ignite/apps/hermes@" + PluginRelayerVersion
 )
 

ignite/templates/app/files/app/ibc.go.plush

@@ -115,9 +115,14 @@ func (app *App) registerIBCModules(appOpts servertypes.AppOptions) error {
 
 	app.IBCKeeper.SetRouter(ibcRouter)
 
-	storeProvider := app.IBCKeeper.ClientKeeper.GetStoreProvider()
+	clientKeeper := app.IBCKeeper.ClientKeeper
+	storeProvider := clientKeeper.GetStoreProvider()
+
 	tmLightClientModule := ibctm.NewLightClientModule(app.appCodec, storeProvider)
+	clientKeeper.AddRoute(ibctm.ModuleName, &tmLightClientModule)
+
 	soloLightClientModule := solomachine.NewLightClientModule(app.appCodec, storeProvider)
+	clientKeeper.AddRoute(solomachine.ModuleName, &soloLightClientModule)
 
 	// register IBC modules
 	if err := app.RegisterModules(

integration/relayer/cmd_relayer_test.go

@@ -26,6 +26,7 @@ import (
 	"github.com/ignite/cli/v29/ignite/pkg/cmdrunner/step"
 	"github.com/ignite/cli/v29/ignite/pkg/errors"
 	"github.com/ignite/cli/v29/ignite/pkg/goanalysis"
+	"github.com/ignite/cli/v29/ignite/pkg/randstr"
 	"github.com/ignite/cli/v29/ignite/pkg/xyaml"
 	envtest "github.com/ignite/cli/v29/integration"
 )
@@ -35,8 +36,8 @@ const (
 )
 
 var (
-	bobName    = "bob"
-	marsConfig = v1.Config{
+	bobName        = "bob"
+	refChainConfig = v1.Config{
 		Config: base.Config{
 			Version: 1,
 			Accounts: []base.Account{
@@ -61,7 +62,7 @@ var (
 				Coins: []string{"500token", "100000000stake"},
 				Host:  ":4501",
 			},
-			Genesis: xyaml.Map{"chain_id": "mars-1"},
+			Genesis: xyaml.Map{"chain_id": randstr.Runes(12)},
 		},
 		Validators: []v1.Validator{
 			{
@@ -77,11 +78,11 @@ var (
 					"p2p": xyaml.Map{"laddr": ":26658"},
 					"rpc": xyaml.Map{"laddr": ":26658", "pprof_laddr": ":6061"},
 				},
-				Home: "$HOME/.mars",
+				Home: filepath.Join(os.TempDir(), randstr.Runes(5)),
 			},
 		},
 	}
-	earthConfig = v1.Config{
+	hostChainConfig = v1.Config{
 		Config: base.Config{
 			Version: 1,
 			Accounts: []base.Account{
@@ -106,7 +107,7 @@ var (
 				Coins: []string{"500token", "100000000stake"},
 				Host:  ":4500",
 			},
-			Genesis: xyaml.Map{"chain_id": "earth-1"},
+			Genesis: xyaml.Map{"chain_id": randstr.Runes(12)},
 		},
 		Validators: []v1.Validator{
 			{
@@ -122,7 +123,7 @@ var (
 					"p2p": xyaml.Map{"laddr": ":26656"},
 					"rpc": xyaml.Map{"laddr": ":26656", "pprof_laddr": ":6060"},
 				},
-				Home: "$HOME/.earth",
+				Home: filepath.Join(os.TempDir(), randstr.Runes(5)),
 			},
 		},
 	}
@@ -384,12 +385,12 @@ func TestBlogIBC(t *testing.T) {
 		availableport.WithMaxPort(5000),
 	)
 	require.NoError(t, err)
-	earthAPI, earthRPC, earthGRPC, earthFaucet := runChain(ctx, t, env, app, earthConfig, tmpDir, ports[:7])
-	earthChainID := earthConfig.Genesis["chain_id"].(string)
-	earthHome := earthConfig.Validators[0].Home
-	marsAPI, marsRPC, marsGRPC, marsFaucet := runChain(ctx, t, env, app, marsConfig, tmpDir, ports[7:])
-	marsChainID := marsConfig.Genesis["chain_id"].(string)
-	marsHome := marsConfig.Validators[0].Home
+	hostChainAPI, hostChainRPC, hostChainGRPC, hostChainFaucet := runChain(ctx, t, env, app, hostChainConfig, tmpDir, ports[:7])
+	hostChainChainID := hostChainConfig.Genesis["chain_id"].(string)
+	hostChainHome := hostChainConfig.Validators[0].Home
+	refChainAPI, refChainRPC, refChainGRPC, refChainFaucet := runChain(ctx, t, env, app, refChainConfig, tmpDir, ports[7:])
+	refChainChainID := refChainConfig.Genesis["chain_id"].(string)
+	refChainHome := refChainConfig.Validators[0].Home
 
 	// check the chains is up
 	stepsCheckChains := step.NewSteps(
@@ -400,10 +401,10 @@ func TestBlogIBC(t *testing.T) {
 				"output", "json",
 			),
 			step.PreExec(func() error {
-				if err := env.IsAppServed(ctx, earthAPI); err != nil {
+				if err := env.IsAppServed(ctx, hostChainAPI); err != nil {
 					return err
 				}
-				return env.IsAppServed(ctx, marsAPI)
+				return env.IsAppServed(ctx, refChainAPI)
 			}),
 		),
 	)
@@ -417,7 +418,7 @@ func TestBlogIBC(t *testing.T) {
 				"install",
 				"-g",
 				// filepath.Join(goenv.GoPath(), "src/github.com/ignite/apps/hermes"), // Local path for test proposals
-				"github.com/ignite/apps/hermes@hermes/v0.2.2",
+				"github.com/ignite/apps/hermes@hermes/v0.2.8",
 			),
 		)),
 	))
@@ -428,14 +429,14 @@ func TestBlogIBC(t *testing.T) {
 				"relayer",
 				"hermes",
 				"configure",
-				earthChainID,
-				earthRPC,
-				earthGRPC,
-				marsChainID,
-				marsRPC,
-				marsGRPC,
-				"--chain-a-faucet", earthFaucet,
-				"--chain-b-faucet", marsFaucet,
+				hostChainChainID,
+				hostChainRPC,
+				hostChainGRPC,
+				refChainChainID,
+				refChainRPC,
+				refChainGRPC,
+				"--chain-a-faucet", hostChainFaucet,
+				"--chain-b-faucet", refChainFaucet,
 				"--generate-wallets",
 				"--overwrite-config",
 			),
@@ -445,7 +446,13 @@ func TestBlogIBC(t *testing.T) {
 	go func() {
 		env.Must(env.Exec("run the hermes relayer",
 			step.NewSteps(step.New(
-				step.Exec(envtest.IgniteApp, "relayer", "hermes", "start", earthChainID, marsChainID),
+				step.Exec(envtest.IgniteApp, "relayer", "hermes", "start", hostChainChainID, refChainChainID),
+				step.PostExec(func(execErr error) error {
+					if execErr != nil {
+						return execErr
+					}
+					return nil
+				}),
 			)),
 			envtest.ExecCtx(ctx),
 		))
@@ -465,7 +472,7 @@ func TestBlogIBC(t *testing.T) {
 				"ibc",
 				"channel",
 				"channels",
-				"--node", earthRPC,
+				"--node", hostChainRPC,
 				"--log_format", "json",
 				"--output", "json",
 			),
@@ -493,7 +500,7 @@ func TestBlogIBC(t *testing.T) {
 		receiverAddr = "cosmos1nrksk5swk6lnmlq670a8kwxmsjnu0ezqts39sa"
 		txOutput     = &bytes.Buffer{}
 		txResponse   struct {
-			Code   int
+			Code   int    `json:"code"`
 			RawLog string `json:"raw_log"`
 			TxHash string `json:"txhash"`
 		}
@@ -512,9 +519,9 @@ func TestBlogIBC(t *testing.T) {
 				receiverAddr,
 				"100000stake",
 				"--from", sender,
-				"--node", earthRPC,
-				"--home", earthHome,
-				"--chain-id", earthChainID,
+				"--node", hostChainRPC,
+				"--home", hostChainHome,
+				"--chain-id", hostChainChainID,
 				"--output", "json",
 				"--log_format", "json",
 				"--keyring-backend", "test",
@@ -533,9 +540,9 @@ func TestBlogIBC(t *testing.T) {
 						"q",
 						"tx",
 						txResponse.TxHash,
-						"--node", earthRPC,
-						"--home", earthHome,
-						"--chain-id", earthChainID,
+						"--node", hostChainRPC,
+						"--home", hostChainHome,
+						"--chain-id", hostChainChainID,
 						"--output", "json",
 						"--log_format", "json",
 					),
@@ -576,9 +583,9 @@ func TestBlogIBC(t *testing.T) {
 				"bank",
 				"balances",
 				receiverAddr,
-				"--node", marsRPC,
-				"--home", marsHome,
-				"--chain-id", marsChainID,
+				"--node", refChainRPC,
+				"--home", refChainHome,
+				"--chain-id", refChainChainID,
 				"--log_format", "json",
 				"--output", "json",
 			),
@@ -604,9 +611,4 @@ func TestBlogIBC(t *testing.T) {
 		),
 	)
 	env.Must(env.Exec("check ibc balance", steps, envtest.ExecRetry()))
-
-	// TODO test ibc using the blog post methods:
-	// step.Exec(app.Binary(), "tx", "blog", "send-ibc-post", "transfer", "channel-0", "Hello", "Hello_Mars-Alice_from_Earth", "--chain-id", earthChainID, "--from", "alice", "--node", earthGRPC, "--output", "json", "--log_format", "json", "--yes")
-	// TODO test ibc using the hermes ft-transfer:
-	// step.Exec(envtest.IgniteApp, "hermes", "exec", "--", "--config", earthConfig, "tx", "ft-transfer", "--timeout-seconds", "1000", "--dst-chain", earthChainID, "--src-chain", marsChainID, "--src-port", "transfer", "--src-channel", "channel-0", "--amount", "100000", "--denom", "stake", "--output", "json", "--log_format", "json", "--yes")
 }