fix: log

Author: ifplusor

src/MQClientInstance.cpp

@@ -113,11 +113,11 @@ void MQClientInstance::Start() {
       service_state_ = ServiceState::kRunning;
       break;
     case ServiceState::kRunning:
-      LOG_INFO_NEW("the client instance [{}] already running.", client_id_, service_state_);
+      LOG_INFO_NEW("the client instance [{}] already running.", client_id_);
       break;
     case ServiceState::kShutdownAlready:
     case ServiceState::kStartFailed:
-      LOG_INFO_NEW("the client instance [{}] start failed with fault state:{}", client_id_, service_state_);
+      LOG_INFO_NEW("the client instance [{}] start failed with fault state:{}", client_id_, ToString(service_state_));
       break;
     default:
       break;

src/common/ServiceState.h

@@ -17,10 +17,25 @@
 #ifndef ROCKETMQ_COMMON_SERVICESTATE_H_
 #define ROCKETMQ_COMMON_SERVICESTATE_H_
 
+#include <string>
+
 namespace rocketmq {
 
 enum class ServiceState { kCreateJust, kRunning, kShutdownAlready, kStartFailed };
 
+inline std::string ToString(ServiceState service_state) {
+  switch (service_state) {
+    case ServiceState::kCreateJust:
+      return "CREATED_JUST";
+    case ServiceState::kRunning:
+      return "RUNNING";
+    case ServiceState::kShutdownAlready:
+      return "SHUTDOWN_ALREADY";
+    case ServiceState::kStartFailed:
+      return "START_FAILED";
+  }
+}
+
 }  // namespace rocketmq
 
 #endif  // ROCKETMQ_COMMON_SERVICESTATE_H_

src/producer/DefaultMQProducerImpl.cpp

@@ -642,8 +642,8 @@ std::unique_ptr<TransactionSendResult> DefaultMQProducerImpl::SendInTransactionI
   try {
     EndTransaction(*send_result, local_transaction_state, local_exception);
   } catch (MQException& e) {
-    LOG_WARN_NEW("local transaction execute {}, but end broker transaction failed: {}", local_transaction_state,
-                 e.what());
+    LOG_WARN_NEW("local transaction execute {}, but end broker transaction failed: {}",
+                 ToString(local_transaction_state), e.what());
   }
 
   // FIXME: setTransactionId will cause OOM?

src/transport/TcpRemotingClient.cpp

@@ -594,7 +594,7 @@ bool TcpRemotingClient::CloseTransport(const std::string& address, const TcpTran
     transport_table_.erase(address);
   }
 
-  LOG_WARN_NEW("closeTransport: disconnect:{} with state:{}", address, channel->LoadStatus());
+  LOG_WARN_NEW("closeTransport: disconnect:{} with state:{}", address, ToString(channel->LoadStatus()));
   if (channel->LoadStatus() != TcpConnectStatus::kClosed) {
     channel->Disconnect(address);  // avoid coredump when connection with server was broken
   }

src/transport/TcpTransport.h

@@ -29,6 +29,21 @@ namespace rocketmq {
 
 enum class TcpConnectStatus { kCreated, kConnecting, kConnected, kFailed, kClosed };
 
+inline std::string ToString(TcpConnectStatus tcp_connect_status) {
+  switch (tcp_connect_status) {
+    case TcpConnectStatus::kCreated:
+      return "CREATED";
+    case TcpConnectStatus::kConnecting:
+      return "CONNECTING";
+    case TcpConnectStatus::kConnected:
+      return "CONNECTED";
+    case TcpConnectStatus::kFailed:
+      return "FAILED";
+    case TcpConnectStatus::kClosed:
+      return "CLOSED";
+  }
+}
+
 class TcpTransport;
 using TcpTransportPtr = std::shared_ptr<TcpTransport>;