Skip to content

refactor the project according to maven-java convention #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 80 commits into
base: master
Choose a base branch
from

Conversation

fazreil
Copy link

@fazreil fazreil commented Oct 10, 2020

In this pull request, I have implemented maven build. To do that I have to reorganize the whole project into maven directory structure. Don't worry because the committer's contribution for each line of the code (when you git blame) is still intact.

Here are some key points for the refactorization:

  • The whole project are structured as a children (modules) of a parent project called Let-Us-Java
  • Each of the individual projects are modules, where they may build on its own
  • There are some project I need to rename just to make them follow Java naming convention (like class name should be similar to the file name, java files should be camel case, take out spaces between names)
  • Fixed compilation issue in Tree (fazreil@004fea5)
  • Fixed code for Tower of Hanoi (fazreil@a940fe8)
  • Fixed dependency for OTPGenerator to use commons-lang library (fazreil@9cd2152)
  • Added reporting feature in pom file to allow document generation. This will allow generation of the site for this project with the javadoc
  • Added profile to do documentation and regular code compilation
  • updated readme to include maven compilation guide
  • included myself as one of the contributor 😃

Bonus

  • added github actions to build and document this project upon push to master.

I appreciate your time spent reading this pull request. Thank you.

You may review my actions page if the code builds accordingly. Project documentation is also uploaded in the github actions tab for you to review before merging.

Pradyuman7 and others added 30 commits October 5, 2020 09:14
Add LeetCode solution folder with one solution
Create MaxConsecutiveOnes.java
Update ReadMe and add a new DP Solution
refactor the project according to maven-java convention
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants