Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flaky playwright status tests #8267

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

holloway
Copy link
Contributor

@holloway holloway commented Nov 23, 2024

Attempts to fix the flaky playwright Status tests by increasing playwright timeout for Status from 5s to 15s

Over 10 20 test runs on CI it passed every time. Did I just get lucky or does this fix it? 🤷

Increasing the timeout doesn't seem to affect the overall playwright test running time in any noticable way in this statistically insignificant sample:
Screenshot from 2024-11-24 17-38-36
(spreadsheet)

Copy link

codecov bot commented Nov 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.96%. Comparing base (7f65171) to head (5ff3663).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8267      +/-   ##
==========================================
+ Coverage   88.94%   88.96%   +0.01%     
==========================================
  Files         303      303              
  Lines       41284    41273      -11     
==========================================
- Hits        36720    36718       -2     
+ Misses       4564     4555       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@holloway holloway requested review from rjsparks and NGPixel November 24, 2024 04:56
@holloway holloway marked this pull request as ready for review November 24, 2024 04:59
@holloway holloway changed the title fix: flakey playwright status tests fix: flaky playwright status tests Nov 24, 2024
@rjsparks rjsparks merged commit a45f10c into ietf-tools:main Nov 25, 2024
9 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants