Skip to content

Throw exception when failing to build coordinate #912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2023
Merged

Throw exception when failing to build coordinate #912

merged 1 commit into from
Oct 17, 2023

Conversation

@t-ober
Copy link
Contributor

@t-ober t-ober commented Oct 16, 2023

Resolves #911

@danielfeismann danielfeismann merged commit b16ae90 into dev Oct 17, 2023
@danielfeismann danielfeismann mentioned this pull request Oct 17, 2023
Open
@sebastian-peter sebastian-peter deleted the to/#911-sql-failed-coordinate-creation branch November 2, 2023 11:13
@sebastian-peter sebastian-peter added this to the Version 4.1 milestone Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielfeismann danielfeismann danielfeismann approved these changes

Assignees

@t-ober t-ober

Labels

None yet

Projects

None yet

Milestone

Version 4.1

Development

Successfully merging this pull request may close these issues.

The SqlIdCoordininateSource just flattens failed coordinate creation away leaving the user no clue about what happened

4 participants

@t-ober @danielfeismann @sebastian-peter