Skip to content

Conversation

@sebastian-peter
Copy link
Member

Resolves #479

@johanneshiry johanneshiry requested review from ckittl and johanneshiry and removed request for johanneshiry January 5, 2022 12:48
@sonarqubegithubprchecks

This comment has been minimized.

@codecov
Copy link

codecov bot commented Jan 5, 2022

Codecov Report

Merging #480 (ef9e7d7) into dev (9776def) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##                dev     #480   +/-   ##
=========================================
  Coverage     78.84%   78.85%           
  Complexity     2107     2107           
=========================================
  Files           259      259           
  Lines          8274     8258   -16     
  Branches        777      775    -2     
=========================================
- Hits           6524     6512   -12     
+ Misses         1357     1353    -4     
  Partials        393      393           
Impacted Files Coverage Δ
...tamodel/io/factory/result/SwitchResultFactory.java 78.57% <0.00%> (-1.43%) ⬇️
...datamodel/io/factory/result/NodeResultFactory.java 81.25% <0.00%> (-1.11%) ⬇️
...amodel/io/factory/result/ThermalResultFactory.java 77.14% <0.00%> (-0.64%) ⬇️
...odel/io/factory/result/ConnectorResultFactory.java 85.41% <0.00%> (-0.30%) ⬇️
.../ie3/datamodel/io/connectors/CsvFileConnector.java 77.91% <0.00%> (-0.27%) ⬇️
...factory/result/SystemParticipantResultFactory.java 91.04% <0.00%> (-0.14%) ⬇️
...n/java/edu/ie3/datamodel/utils/ContainerUtils.java 82.62% <0.00%> (-0.07%) ⬇️
...edu/ie3/datamodel/io/source/csv/CsvDataSource.java 94.31% <0.00%> (ø)
...3/datamodel/io/factory/input/LineInputFactory.java 76.47% <0.00%> (ø)
...amodel/models/input/container/GraphicElements.java 91.89% <0.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6e16dc...ef9e7d7. Read the comment docs.

@sonarqubegithubprchecks
Copy link

Passed

Analysis Details

0 Issues

  • Bug0 Bugs
  • Vulnerability0 Vulnerabilities
  • Code Smell0 Code Smells

Coverage and Duplications

  • 100 percent coverage100.00% Coverage (77.80% Estimated after merge)
  • 3 percent duplication0.00% Duplicated Code (0.20% Estimated after merge)

Project ID: edu.ie3:PowerSystemDataModel

View in SonarQube

@sebastian-peter sebastian-peter marked this pull request as ready for review January 5, 2022 17:19
@johanneshiry johanneshiry merged commit 922fb79 into dev Jan 5, 2022
@sebastian-peter sebastian-peter deleted the sp/#479-java-17 branch January 5, 2022 17:34
@sebastian-peter sebastian-peter added this to the Version 3.0 milestone Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrading to Java 17

3 participants