Skip to content

Added a null check on the operators collection #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 30, 2021

Conversation

avgprog
Copy link
Contributor

@avgprog avgprog commented Mar 27, 2021

Resolves #264. Changes done:

  • Added a null check on the operators Collection. If the Collection is null, OperatorInput.NO_OPERATOR_ASSIGNED will be returned by the getFirstOrDefaultOperator() function.

@avgprog avgprog changed the title #264 Added a null check on the operators collection Added a null check on the operators collection Mar 27, 2021
@avgprog avgprog self-assigned this Mar 27, 2021
@avgprog avgprog requested a review from johanneshiry March 27, 2021 13:37
@codecov
Copy link

codecov bot commented Mar 30, 2021

Codecov Report

Merging #313 (44bd86e) into dev (ba2860c) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##                dev     #313   +/-   ##
=========================================
  Coverage     77.98%   77.98%           
  Complexity     1951     1951           
=========================================
  Files           249      249           
  Lines          7935     7936    +1     
  Branches        749      749           
=========================================
+ Hits           6188     6189    +1     
  Misses         1321     1321           
  Partials        426      426           
Impacted Files Coverage Δ Complexity Δ
...edu/ie3/datamodel/io/source/csv/CsvDataSource.java 90.11% <0.00%> (+0.05%) 54.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47b429c...44bd86e. Read the comment docs.

@ckittl ckittl merged commit 68e79b0 into dev Mar 30, 2021
@ckittl ckittl deleted the sb/#264-handlingExceptionInCSVDataSource branch March 30, 2021 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NullPointerException when no operator headline in .csv file is present
2 participants