-
Notifications
You must be signed in to change notification settings - Fork 35
Simplify deployment ignition: add recover solution #372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
daveroga
wants to merge
51
commits into
chore/simplify-deployment-ignition
Choose a base branch
from
chore/simplify-deployment-ignition-recover-journal
base: chore/simplify-deployment-ignition
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Simplify deployment ignition: add recover solution #372
daveroga
wants to merge
51
commits into
chore/simplify-deployment-ignition
from
chore/simplify-deployment-ignition-recover-journal
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 15639332474Details
💛 - Coveralls |
e49a439
to
3c1b6ac
Compare
a87fb48
to
b098815
Compare
c12bc5b
to
08c3ed7
Compare
5f37223
to
9d3cd25
Compare
* fix checking unified contracts multi-chain * fix vulnerabilities
* Add legacy address for cross chain proof validator (#373) * Add legacy address for cross chain proof validator * Remove legacy address from constructor * Add setCrossChainProofValidator call to deploy script * Add billions networks to configs * Add billions networks to configs 2 * Fix tests * Fix network naming * Fix network naming 2 * Update scripts/maintenance/multi-chain/checkOracleSigningAddress.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Revert "Update scripts/maintenance/multi-chain/checkOracleSigningAddress.ts" This reverts commit 573e791. * Bump package version --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Add deploy script * Remove whitelisting validators from deploy script * Add ignition deployment artifacts for Universal Verifier test wrapper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to difficulty to work with ignition for dinamically deploy or get contracts from ignition modules if we don't have
journal
built from ignition we should useparameters
at this moment in these ignition modules and a strategy to recover contracts deployed at some point.This is PR to be merged against #371