Skip to content

Conversation

@Numpsy
Copy link
Contributor

@Numpsy Numpsy commented Oct 7, 2021

As suggested in #630

I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.

@codecov
Copy link

codecov bot commented Oct 7, 2021

Codecov Report

Merging #670 (82b2106) into master (b5b1a92) will increase coverage by 0.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #670      +/-   ##
==========================================
+ Coverage   73.07%   73.31%   +0.24%     
==========================================
  Files          68       68              
  Lines        8305     8305              
==========================================
+ Hits         6069     6089      +20     
+ Misses       2236     2216      -20     
Impacted Files Coverage Δ
...ode.SharpZipLib/Zip/Compression/DeflaterHuffman.cs 97.87% <0.00%> (+6.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5b1a92...82b2106. Read the comment docs.

@Numpsy
Copy link
Contributor Author

Numpsy commented Oct 7, 2021

'interesting' how #630 talks about unstable coverage, and this is showing a coverage change in the deflater code that should be unaffected by the change :-(

@piksel
Copy link
Member

piksel commented Oct 8, 2021

Yeah, there are still randomness in the test cases which causes some areas to only be covered with the "correct" seed.

@piksel
Copy link
Member

piksel commented Oct 9, 2021

I have gone through all tests using Random and replaced them with deterministic pseudo random data in #671. This should stabilize the test coverage...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants