Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve "Unresolved references" banner #2036

Open
dgrunwald opened this issue Jun 13, 2020 · 0 comments
Open

Improve "Unresolved references" banner #2036

dgrunwald opened this issue Jun 13, 2020 · 0 comments
Labels
Decompiler The decompiler engine itself Enhancement Areas for improvement UI

Comments

@dgrunwald
Copy link
Member

This warning currently appears if there are unresolved assembly references.

However:

  1. The banner shows up unnecessarily if the method being decompiled does not use any types from the missing assembly.
  2. The banner does not show up when types are missing for decompilation because ILSpy has loaded a different version of the assembly.

The banner should be triggered by "unknown type" errors (TS falling back to UnknownType) instead of of "assembly not found" errors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Decompiler The decompiler engine itself Enhancement Areas for improvement UI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dgrunwald @siegfriedpammer