From 5b2b019f83edc840aa598829c027047e67d5dba3 Mon Sep 17 00:00:00 2001 From: Cuong Nguyen <128072568+can-anyscale@users.noreply.github.com> Date: Tue, 14 May 2024 16:51:50 -0700 Subject: [PATCH] [ci] skip the failing cpp tests on mac (#45273) Skip the current failing cpp tests on mac so that it can pass. It currently soft-fails, hinders other errors, etc. Test: - https://buildkite.com/ray-project/premerge/builds/25983#018f69fc-44dc-4329-b5af-0dcfdd59d74b Signed-off-by: can --- .buildkite/macos/macos.rayci.yml | 1 - ci/ci.sh | 10 ++++++---- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/.buildkite/macos/macos.rayci.yml b/.buildkite/macos/macos.rayci.yml index f41488d74cc3..440a41bfb56d 100644 --- a/.buildkite/macos/macos.rayci.yml +++ b/.buildkite/macos/macos.rayci.yml @@ -100,7 +100,6 @@ steps: - oss job_env: MACOS instance_type: macos - soft_fail: true commands: - RAY_INSTALL_JAVA=1 ./ci/ray_ci/macos/macos_ci.sh run_ray_cpp_and_java diff --git a/ci/ci.sh b/ci/ci.sh index 1c100c8c0e1a..d8bf17a615a1 100755 --- a/ci/ci.sh +++ b/ci/ci.sh @@ -302,10 +302,12 @@ test_cpp() { --test_arg=--ray_redis_password="1234" bazel test --test_output=all //cpp:test_python_call_cpp - # run the cpp example - rm -rf ray-template - ray cpp --generate-bazel-project-template-to ray-template - pushd ray-template && bash run.sh + # run the cpp example, currently does not work on mac + if [[ "${OSTYPE}" != darwin* ]]; then + rm -rf ray-template + ray cpp --generate-bazel-project-template-to ray-template + pushd ray-template && bash run.sh + fi } test_wheels() {