Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First impressions and minor issues #363

Closed
jcmrva opened this issue Sep 25, 2022 · 4 comments
Closed

First impressions and minor issues #363

jcmrva opened this issue Sep 25, 2022 · 4 comments

Comments

@jcmrva
Copy link

jcmrva commented Sep 25, 2022

I've been meaning to try this since I saw it on a "cool Elm apps" post a while back. The release notice prompted me to finally set up some music for it. Very cool! This will be a good alternative to finding tracks on YT @ work.

Some observations, mostly:

Firefox appears to be supported but it spins indefinitely at this point. No console errors.
diffuse-ff-noload

Lots of music players are more forgiving about broken/missing metadata, so I didn't notice some of my files had issues until I uploaded them. Then I found that fixing them (via Azure blob service) is a bit tedious: delete the file, process the source to get it out of the app, upload the fixed file, process again.

The Ctrl + _ shortcuts work but also perform browswer functions. I see there was an issue about this - mentioning it again just in case.

  • K focuses the browser URL bar.
  • 1-x switches browser tabs.

The volume slider doesn't appear on the album view.

I like the track highlight changing along with the background, but that can result in low contrast depending on the image.
diffuse-nowplaying-contrast

If an artist has multiple albums (with covers), it would be nice if the artist view had a collage of some kind, e.g.
image

Good job handling super long track titles and special characters - I haven't found anything that breaks it yet. 😁
image

Noticed this comment - what happens when we exceed 1000 items?

@icidasset
Copy link
Owner

icidasset commented Sep 26, 2022

Hi, thank you for all the feedback! ☺️

Firefox appears to be supported but it spins indefinitely at this point. No console errors.

This is most likely because it's downloading all the application files and all the background images (25MB total) in the background so that the application works offline (done through service worker). Sometimes it takes a while, especially if the server is slow to respond. Does it still happen when you refresh?

I should probably make it so that it doesn't download all the background images, but just the ones it actually uses 🤔

Then I found that fixing them (via Azure blob service) is a bit tedious: delete the file, process the source to get it out of the app, upload the fixed file, process again.

There's a shortcut for this. If you hold the OPTION (I think that's ALT on non-Mac devices) and right-click on a track, you should get the option to "sync tags".

The Ctrl + _ shortcuts work but also perform browswer functions

Not sure if I can do anything about that. Suggestions are welcome!

The volume slider doesn't appear on the album view.

Oh that's new, it should be there. Can you send me a screenshot? And device + browser info 🙏

can result in low contrast depending on the image.

Need to create an issue for this 👀

it would be nice if the artist view had a collage of some kind, e.g.

Could be cool yeah, good suggestion 👍

I haven't found anything that breaks it yet.

🎉

what happens when we exceed 1000 items?

What happens is what is described in the issue. Too much data for the code to process at once or something like that, hard to tell exactly.

@jcmrva
Copy link
Author

jcmrva commented Sep 26, 2022

Firefox appears to be supported but it spins indefinitely at this point. No console errors.

This is most likely because it's downloading all the application files and all the background images (25MB total) in the background so that the application works offline (done through service worker). Sometimes it takes a while, especially if the server is slow to respond. Does it still happen when you refresh?

I let it sit for ~5 minutes and figured that was enough. Not sure what the issue was but it's working on FF on my other machine now at least.

The volume slider doesn't appear on the album view.

Oh that's new, it should be there. Can you send me a screenshot? And device + browser info 🙏

image
Not much to see... I click and nothing happens. Tried double-clicking just in case. Win 10, latest Firefox & Chrome.

what happens when we exceed 1000 items?

What happens is what is described in the issue. Too much data for the code to process at once or something like that, hard to tell exactly.

Sorry, I meant: does it make multiple requests or only get the first 1000?

@icidasset
Copy link
Owner

Thanks! I'll look into these issues.

Sorry, I meant: does it make multiple requests or only get the first 1000?

Oh yeah definitely multiple requests, it's in batches of 1000.

@icidasset
Copy link
Owner

Tracking these issues in:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants