Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more file formats #110

Closed
icidasset opened this issue Jun 17, 2018 · 12 comments
Closed

Support more file formats #110

icidasset opened this issue Jun 17, 2018 · 12 comments
Milestone

Comments

@icidasset
Copy link
Owner

HTML5 Audio element supports these as well: wav, ogg, webm.

Note: UI should show notification when audio element in (older) browser does not support the file format.

I don’t know if there’s a Javascript library out there that can read any of these file formats.

@icidasset icidasset added this to the 1.1.0 milestone Jun 17, 2018
@icidasset icidasset modified the milestones: 1.1.0, 1.0.0 Jun 23, 2018
@icidasset
Copy link
Owner Author

Will implement Borewit/music-metadata#107 when available.

@icidasset icidasset modified the milestones: 1.0.0, 1.1.0 Jul 6, 2018
@Borewit
Copy link
Contributor

Borewit commented Aug 17, 2018

WebM is a video format, if you open an issue and include at least one sample (with metadata), I can check if I can make it working. Opus, which is as well Ogg based, is supported.

Are you sure you need browser support? Most Electron based apps use the ability of Node.js to read the metadata:

@icidasset
Copy link
Owner Author

Thanks @Borewit ! Yeah I would need browser support. I have a web (ie. non-electron) version of my application, the native version is just an extra. I only use node.js when there's no other way to do something. I'm probably even going to switch to a Haskell library instead of Electron somewhere in the future.

@Borewit
Copy link
Contributor

Borewit commented Aug 18, 2018

@icidasset:

Haskell, I used that on university a long time ago. But that is an alternative to JavaScript, not to Electron directly.

With a bit of tweaking you should already be able to use music-metadata in the browser.

Using webpack, you should filter out the Node fs dependency.

Are you willing to give it a try and share your experience? That would help to closing the gap.

@icidasset
Copy link
Owner Author

@Borewit Yeah, definitely. That's why I said "a Haskell library". I was thinking of https://github.com/lettier/webviewhs

I'm going to give it a try, thanks! 😄
Not a webpack user here though, but I'll see what I can come up with.

@Borewit
Copy link
Contributor

Borewit commented Aug 25, 2018

You maybe interested in the experimental browser version: music-metadata-browser

@icidasset
Copy link
Owner Author

@Borewit Awesome thanks! Will check it out soon, taking a little break at the moment.

@icidasset icidasset modified the milestones: 1.1.0, 2.0.0 Oct 22, 2018
@icidasset
Copy link
Owner Author

TODO: Implement music-metadata-browser in v2 as soon as Borewit/music-metadata-browser#4 is ready.

@Borewit
Copy link
Contributor

Borewit commented Nov 3, 2018

Should be good to go, let me know if you experience any issues.

@icidasset
Copy link
Owner Author

@Borewit Thanks for all the hard work you do! Really appreciated. But I was actually waiting on support for the range header 😅 I need to scan over 200GB of music, so it would be quite unfeasible to download all of that.

@Borewit
Copy link
Contributor

Borewit commented Nov 6, 2018

Check: streaming-http-token-reader.

Looking forward to hear from you is it meets your requirements.

@icidasset
Copy link
Owner Author

Implemented in #128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants